Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spawn items you can't pick up in MP #200

Closed
tobiasksu opened this issue Jan 7, 2022 · 4 comments · Fixed by #203
Closed

Don't spawn items you can't pick up in MP #200

tobiasksu opened this issue Jan 7, 2022 · 4 comments · Fixed by #203
Assignees
Labels
bug Something isn't working Multiplayer General multiplayer issues.

Comments

@tobiasksu
Copy link
Collaborator

The "Ascent Issue" - ignore items like CM health spawns which display on client but can't truly be picked up

@tobiasksu tobiasksu self-assigned this Jan 7, 2022
@tobiasksu tobiasksu added the Multiplayer General multiplayer issues. label Jan 7, 2022
@roncli roncli added the bug Something isn't working label Jan 7, 2022
@luponix
Copy link
Member

luponix commented Jan 7, 2022

they need to be synced instead of ignored as the very first time that someone goes through them they are a valid pickup. after that first pickup they just never get deleted on the other clients and remain as ghosts with no effect

Edit: a good reason to keep that functionality is that it is the only way for level makers to define specific item spawns in mp afaik

@roncli
Copy link
Member

roncli commented Jan 12, 2022

My suggestion is to resolve the bug for now as suggested, and if it's wanted to be able to make specific item spawns in multiplayer we can address that separately, since that would carry additional considerations (What comes back in its place when it respawns? What should the respawn timer be for them?).

To fix the bug, I'd convert these spawns to normal spawn points, rather than remove them entirely.

@tobiasksu
Copy link
Collaborator Author

Currently have some code I'm testing that seems to work OK that handles it similarly to @luponix 's suggestion, e.g. in the Ascent scenario it detects health orbs with invalid netIds, destroys them, and then respawns a one-use sync'd replacement.

I think @roncli 's "additional considerations" questions are good and raise the point of whether or not I should look at adding in that exact behavior that I implemented for Miasmic's arena mode mod into olmod if mapmakers want to use that. I'll create a separate improvement issue to pull that code over into olmod at some point in the future.

@roncli
Copy link
Member

roncli commented Jan 14, 2022

I'd go with the one-use sync'd replacement, that keeps the items in the game and makes them do what you'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Multiplayer General multiplayer issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants