From e3d1fc48203e55594f6b6de22ac1247b4a7e1aca Mon Sep 17 00:00:00 2001 From: robobun <117481402+robobun@users.noreply.github.com> Date: Tue, 22 Sep 2026 19:35:54 +0000 Subject: [PATCH] ci: bump mordant to 00778d3 so that the unused_pub count is stable At d0dca00 the job passes or fails at random. `cargo mordant` reported three associated constants of `bun_sys::Tag` two or three times each, depending on the order in which cargo finished the three targets, so the unused_pub count for src/sys/lib.rs was 65 or 68 over the same code. 00778d3 matches and reports an item by its position (crate, file, offset of the name) and no longer by a key that differs per target. The count no longer depends on the order. It also stops reporting items that only one target uses, which the other targets' records made look unused, and it reports items that share a name under different cfgs one by one. The regenerated baseline only goes down: src/sys/lib.rs 65 to 56, and the entries for src/io/lib.rs (1) and src/spawn_sys/spawn_process.rs (5) are gone. --- .github/workflows/rust-lints.yml | 2 +- mordant-baseline.toml | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust-lints.yml b/.github/workflows/rust-lints.yml index d8e5f6909455..f51302636a6c 100644 --- a/.github/workflows/rust-lints.yml +++ b/.github/workflows/rust-lints.yml @@ -132,7 +132,7 @@ jobs: # The pinned commit of https://github.com/scarletindustries/mordant. # Bumping it is a PR of its own, where whatever the new revision finds # gets fixed or added to mordant-baseline.toml. - MORDANT_REV: d0dca0026f0662a94e929a8a697d711be5eafd9b + MORDANT_REV: 00778d35391dc1a75381008754fd40726c1682f0 # The nightly in mordant's rust-toolchain file at MORDANT_REV. mordant is # built with it and links its rustc, so it is also the compiler that # checks this workspace while the lints run, and it must still be able diff --git a/mordant-baseline.toml b/mordant-baseline.toml index 91ec55969d94..78e960d63347 100644 --- a/mordant-baseline.toml +++ b/mordant-baseline.toml @@ -53,7 +53,6 @@ "generic_body_not_generic:src/io/pipes.rs" = 1 "param_wider_than_callers:src/io/PipeWriter.rs" = 1 "unused_pub:src/io/PipeWriter.rs" = 2 -"unused_pub:src/io/lib.rs" = 1 [bun_js_parser] "generic_body_not_generic:src/js_parser/fold.rs" = 1 @@ -168,9 +167,6 @@ [bun_spawn] "unused_pub:src/spawn/process.rs" = 1 -[bun_spawn_sys] -"unused_pub:src/spawn_sys/spawn_process.rs" = 5 - [bun_sql_jsc] "generic_body_not_generic:src/sql_jsc/mysql/JSMySQLConnection.rs" = 1 "generic_body_not_generic:src/sql_jsc/mysql/MySQLConnection.rs" = 4 @@ -179,7 +175,7 @@ [bun_sys] "error_collapsed_to_bool:src/sys/lib.rs" = 4 -"unused_pub:src/sys/lib.rs" = 65 +"unused_pub:src/sys/lib.rs" = 56 "unused_pub:src/sys/windows/mod.rs" = 5 [bun_uws_sys]