From b618f4370e625c568c940307e17263e94e647a90 Mon Sep 17 00:00:00 2001 From: robobun <117481402+robobun@users.noreply.github.com> Date: Thu, 16 Jul 2026 07:47:05 +0000 Subject: [PATCH] test: unquarantine the three Bun-owned http2 suites The http2 rewrite (6ef59777b60) quarantined its own regression suites while the engine was still being reconciled. All three now pass 3/3 on darwin-arm64, linux-x64, and windows-x64 against 1.4.0-canary.1+c4fad462e: node-http2.test.js 294 pass / 6 skip / 0 fail / 12217 expect() h2-conformance.test.ts 37 pass / 0 fail / 66 expect() / 2 snapshots node-http2-invalid-padding.test.ts 7 pass / 0 fail / 22 expect() These entries carried no platform modifier, so getRelevantTests in scripts/runner.node.mjs removed the files from every lane, leaving the rewritten engine with its own regression suite switched off. The [ ASAN ] prefix skip for test/js/node/http2/ and the platform-scoped [ LINUX ]/[ WINDOWS ] parallel-suite entries remain; they cover separate socket-layer issues and are out of scope here. --- test/expectations.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/expectations.txt b/test/expectations.txt index 0ae9e1be3a58..d3b5c6346d08 100644 --- a/test/expectations.txt +++ b/test/expectations.txt @@ -235,14 +235,6 @@ test/js/node/test/parallel/test-http2-session-cleanup-on-nghttp2-goaway.js [ SKI [ ASAN ] test/js/node/test/parallel/test-http2-client-unescaped-path.js [ SKIP ] # ASan report under investigation [ ASAN ] test/js/node/test/parallel/test-http2-buffersize.js [ SKIP ] # ASan report under investigation -# The bun-specific http2 integration suites are being reconciled with the rewritten -# (node-faithful) HTTP/2 engine: several of their expectations pin legacy-parser behaviors -# that contradict node's (e.g. 'ping' events for PING ACKs, connection-error codes for -# wrong-size frames that RFC 9113 defines as stream errors). Tracked for reconciliation; -# the ported node parallel suite covers the node-faithful contract. -test/js/node/http2/node-http2.test.js [ FAIL ] # legacy-parser expectations under reconciliation -test/js/node/http2/h2-conformance.test.ts [ FAIL ] # under reconciliation with the rewritten engine (CONTINUATION flood + RST rate-limit cases) -test/js/node/http2/node-http2-invalid-padding.test.ts [ FAIL ] # legacy-parser expectations under reconciliation [ ASAN ] test/js/third_party/grpc-js/test-server.test.ts [ SKIP ] # connect-race socket lifetime report under investigation [ WINDOWS ] test/js/third_party/grpc-js/test-server.test.ts [ FAIL ] # http2 teardown gap on Windows