Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pty unable to be run from bun #7362

Closed
Moosems opened this issue Nov 29, 2023 · 6 comments
Closed

node-pty unable to be run from bun #7362

Moosems opened this issue Nov 29, 2023 · 6 comments
Labels
bug Something isn't working napi Compatibility with the native layer of Node.js

Comments

@Moosems
Copy link

Moosems commented Nov 29, 2023

What version of Bun is running?

1.0.14

What platform is your computer?

Darwin 18.7.0 x86_64 i386

What steps can reproduce the bug?

mkdir example
cd example
bun install node-pty
echo "var pty = require('node-pty');" >> test.js
bun test.js

What is the expected behavior?

It runs without an issue.

What do you see instead?

dyld: lazy symbol binding failed: Symbol not found: _node_module_register
  Referenced from: /Users/Moosems/Desktop/PyQtXtermApp/node_modules/node-pty/build/Release/pty.node
  Expected in: flat namespace

dyld: Symbol not found: _node_module_register
  Referenced from: /Users/Moosems/Desktop/PyQtXtermApp/node_modules/node-pty/build/Release/pty.node
  Expected in: flat namespace

Additional information

Works fine with npm.

@Moosems Moosems added the bug Something isn't working label Nov 29, 2023
@Electroid Electroid added the napi Compatibility with the native layer of Node.js label Nov 29, 2023
@kkocdko
Copy link

kkocdko commented Dec 15, 2023

Old node-pty uses NAN, not NAPI. The future work about port node-pty to NAPI is here microsoft/node-pty#644 .

Please close this issue.

@Moosems
Copy link
Author

Moosems commented Dec 16, 2023

I think I'll keep it open until it's merged and a release with the changes comes out :). I didn't add the NAPI label anyway. In that PR someone even tried this and it didn't work.

@benhylak
Copy link

Hitting this, not able to use Bun.

@metawrap-dev
Copy link

Same

dyld: lazy symbol binding failed: Symbol not found: _node_module_register
  Referenced from: /Users/james/metawrap/node_modules/canvas/build/Release/canvas.node
  Expected in: flat namespace

dyld: Symbol not found: _node_module_register
  Referenced from: /Users/james/metawrap/node_modules/canvas/build/Release/canvas.node
  Expected in: flat namespace

@terrywh
Copy link

terrywh commented Feb 27, 2024

not possible? microsoft/node-pty#632 (comment)

@Jarred-Sumner
Copy link
Collaborator

Please follow along in #4290

@190n is actively working on supporting V8 C++ APIs in Bun

@Jarred-Sumner Jarred-Sumner closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working napi Compatibility with the native layer of Node.js
Projects
None yet
Development

No branches or pull requests

7 participants