Merge pull request #133 from RomkaLTU/fix-possible-empty-string

KasparRosin · web-flow · commit 7af5faee85d9 · 2024-09-12T18:10:15.000+03:00
Fix cast issue in TranslatableFieldMixin
diff --git a/src/TranslatableFieldMixin.php b/src/TranslatableFieldMixin.php
@@ -76,7 +76,7 @@ public function translatable()
                     : config('nova-translatable.fill_other_locales_from', null);
 
                 // Fix strings being casted to floats
-                if ($this instanceof Text && !$this instanceof Number) {
+                if ($this instanceof Text && !$this instanceof Number && !empty($value)) {
                     foreach ($value as $key => $val) {
                         $value[$key] = ($val === null ? null : (string) $val);
                     }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function translatable()`
`76`	`76`	`: config('nova-translatable.fill_other_locales_from', null);`
`77`	`77`
`78`	`78`	`// Fix strings being casted to floats`
`79`		`- if ($this instanceof Text && !$this instanceof Number) {`
	`79`	`+ if ($this instanceof Text && !$this instanceof Number && !empty($value)) {`
`80`	`80`	`foreach ($value as $key => $val) {`
`81`	`81`	`$value[$key] = ($val === null ? null : (string) $val);`
`82`	`82`	`}`