Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova tabs compatibility #120

Open
stepanenko3 opened this issue May 1, 2022 · 9 comments
Open

Nova tabs compatibility #120

stepanenko3 opened this issue May 1, 2022 · 9 comments

Comments

@stepanenko3
Copy link

Tabs are not displayed on the settings page
Tabs package eminiarts/nova-tabs

@Tarpsvo
Copy link
Collaborator

Tarpsvo commented May 13, 2022

Hi! Nova tabs reworked their package quite a bit since v1 and it's no longer possible to easily support the Tabs package. It requires a lot of custom integration code, as they mutate the Panel a lot on the server side. If you want Tabs support, you can try to implement it and submit a PR. :) Thanks.

@mucenica-bogdan
Copy link

I had a first pass at it and it requires a fair amount of rework.
I'll give it another go during the weekend, hopefully I can get it to work.

@stepanenko3 - in the mean time in my projects i've changed back to native Panels instead of tabs.

@rgdigital
Copy link

@Tarpsvo - Just to check, is the tabbed UI in the screenshot for legacy versions only or is there native support for tabs now?
https://raw.githubusercontent.com/outl1ne/nova-settings/main/docs/index.png

@Tarpsvo
Copy link
Collaborator

Tarpsvo commented Jul 1, 2022

Sorry about that - that is indeed an old screenshot from Nova V3.

@Violet-Vibes
Copy link

I had a first pass at it and it requires a fair amount of rework. I'll give it another go during the weekend, hopefully I can get it to work.

@stepanenko3 - in the mean time in my projects i've changed back to native Panels instead of tabs.

Any update on this? Would love to have tab support for this <3

@stepanenko3
Copy link
Author

@Violet-Vibes,

I didn't get NovaTabs support and made my package nova-settings

@Violet-Vibes
Copy link

@Violet-Vibes,

I didn't get NovaTabs support and made my package nova-settings

@stepanenko3 Oh, interesting! Is there an easy way to migrate usage of nova_get_setting and the other helper functions to your package?

@stepanenko3
Copy link
Author

@Violet-Vibes,
I didn't get NovaTabs support and made my package nova-settings

@stepanenko3 Oh, interesting! Is there an easy way to migrate usage of nova_get_setting and the other helper functions to your package?

Of course

function settings(string|null $section, string|null $key = null, string|null $default = null, string|null $env = null)

Get cart_link value from General settings in current Env

settings('general', 'cart_link')

Get all General settings

settings('general')

Get cart_link value from General settings in specific Env with default value

settings(
    section: 'general',
    key: 'cart_link',
    default: true,
    env: 'production'
);

// OR

settings('general', 'cart_link', true, 'production');

@Violet-Vibes
Copy link

I'll have a look at it, thanks @stepanenko3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants