Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable workflow_dispatch and attach debug APK for Android CI #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbekkomo
Copy link

Closes #335

Changes to Android CI (android.yml):

  • Enable workflow_dispatch
  • Attach debug APK and SHA256 checksum file

@Rian8337
Copy link
Member

Is there a reason for running the workflow on every push?

@mbekkomo
Copy link
Author

Is there a reason for running the workflow on every push?

It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path?

@Rian8337
Copy link
Member

Apologies, I meant to ask about the artifact part.

@mbekkomo
Copy link
Author

If you meant why is it need to be attach with APK artifact, see the issue I referenced.

@Rian8337
Copy link
Member

I understand why, but I don't understand why the APK artifact must be attached on every push or pull request.

@mbekkomo
Copy link
Author

There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by workflow_dispatch event.

@Rian8337
Copy link
Member

or restrict it at all and only attach if it's triggered by workflow_dispatch event.

I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in.

@mbekkomo
Copy link
Author

Then disabling it via commit message could work, such as noci or skipci at the end of commit message.

@Rian8337
Copy link
Member

so it should be opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make android.yml workflow to output APK artifacts
2 participants