Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseAndRenderString() panics for certain arguments #90

Closed
2 tasks done
magiusdarrigo opened this issue Aug 6, 2024 · 1 comment
Closed
2 tasks done

ParseAndRenderString() panics for certain arguments #90

magiusdarrigo opened this issue Aug 6, 2024 · 1 comment

Comments

@magiusdarrigo
Copy link
Contributor

magiusdarrigo commented Aug 6, 2024

Checklist

  • I have searched the issue list
  • I have tested my example against Shopify Liquid. (This isn't necessary if the actual behavior is a panic, or an error for which IsTemplateError returns false.)

Expected Behavior

Gracefully returns an error

Actual Behavior

Panics

Detailed Description

I have the line of code:

result, err := lqEngine.ParseAndRenderString(template, bindings)
if template equals the string: {% if %} the line panics.

Possible Solution

PR

@magiusdarrigo
Copy link
Contributor Author

Pull request with patch made - #91

cc: @danog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant