Skip to content

Commit a6fe4e8

Browse files
committed
For #1547, remove the SRS_OSX macro in code
1 parent 024433f commit a6fe4e8

File tree

5 files changed

+9
-110
lines changed

5 files changed

+9
-110
lines changed

trunk/auto/depends.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ function Ubuntu_prepare()
9696
if [[ $SRS_VALGRIND == YES ]]; then
9797
if [[ ! -f /usr/include/valgrind/valgrind.h ]]; then
9898
echo "Installing valgrind-dev."
99-
require_sudoer "sudo apt-get install -y --force-yes valgrind-dev"
99+
require_sudoer "sudo apt-get install -y --force-yes valgrind-dbg"
100100
sudo apt-get install -y --force-yes valgrind-dev; ret=$?; if [[ 0 -ne $ret ]]; then return $ret; fi
101101
echo "The valgrind-dev is installed."
102102
fi

trunk/src/app/srs_app_utility.cpp

+6-86
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@
3131
#include <sys/wait.h>
3232
#include <netdb.h>
3333

34-
#ifdef SRS_OSX
35-
#include <sys/sysctl.h>
36-
#endif
3734
#include <stdlib.h>
3835
#include <sys/time.h>
3936
#include <math.h>
@@ -329,7 +326,6 @@ SrsProcSystemStat* srs_get_system_proc_stat()
329326

330327
bool get_proc_system_stat(SrsProcSystemStat& r)
331328
{
332-
#ifndef SRS_OSX
333329
FILE* f = fopen("/proc/stat", "r");
334330
if (f == NULL) {
335331
srs_warn("open system cpu stat failed, ignore");
@@ -359,18 +355,14 @@ bool get_proc_system_stat(SrsProcSystemStat& r)
359355
}
360356

361357
fclose(f);
362-
#else
363-
// TODO: FIXME: impelments it.
364-
#endif
365-
358+
366359
r.ok = true;
367360

368361
return true;
369362
}
370363

371364
bool get_proc_self_stat(SrsProcSelfStat& r)
372365
{
373-
#ifndef SRS_OSX
374366
FILE* f = fopen("/proc/self/stat", "r");
375367
if (f == NULL) {
376368
srs_warn("open self cpu stat failed, ignore");
@@ -397,10 +389,7 @@ bool get_proc_self_stat(SrsProcSelfStat& r)
397389
&r.guest_time, &r.cguest_time);
398390

399391
fclose(f);
400-
#else
401-
// TODO: FIXME: impelments it.
402-
#endif
403-
392+
404393
r.ok = true;
405394

406395
return true;
@@ -495,7 +484,6 @@ SrsDiskStat* srs_get_disk_stat()
495484

496485
bool srs_get_disk_vmstat_stat(SrsDiskStat& r)
497486
{
498-
#ifndef SRS_OSX
499487
FILE* f = fopen("/proc/vmstat", "r");
500488
if (f == NULL) {
501489
srs_warn("open vmstat failed, ignore");
@@ -515,10 +503,7 @@ bool srs_get_disk_vmstat_stat(SrsDiskStat& r)
515503
}
516504

517505
fclose(f);
518-
#else
519-
// TODO: FIXME: impelments it.
520-
#endif
521-
506+
522507
r.ok = true;
523508

524509
return true;
@@ -535,7 +520,6 @@ bool srs_get_disk_diskstats_stat(SrsDiskStat& r)
535520
return true;
536521
}
537522

538-
#ifndef SRS_OSX
539523
FILE* f = fopen("/proc/diskstats", "r");
540524
if (f == NULL) {
541525
srs_warn("open vmstat failed, ignore");
@@ -600,10 +584,7 @@ bool srs_get_disk_diskstats_stat(SrsDiskStat& r)
600584
}
601585

602586
fclose(f);
603-
#else
604-
// TODO: FIXME: impelments it.
605-
#endif
606-
587+
607588
r.ok = true;
608589

609590
return true;
@@ -695,7 +676,6 @@ void srs_update_meminfo()
695676
{
696677
SrsMemInfo& r = _srs_system_meminfo;
697678

698-
#ifndef SRS_OSX
699679
FILE* f = fopen("/proc/meminfo", "r");
700680
if (f == NULL) {
701681
srs_warn("open meminfo failed, ignore");
@@ -721,10 +701,7 @@ void srs_update_meminfo()
721701
}
722702

723703
fclose(f);
724-
#else
725-
// TODO: FIXME: impelments it.
726-
#endif
727-
704+
728705
r.sample_time = srsu2ms(srs_get_system_time());
729706
r.MemActive = r.MemTotal - r.MemFree;
730707
r.RealInUse = r.MemActive - r.Buffers - r.Cached;
@@ -791,7 +768,6 @@ void srs_update_platform_info()
791768

792769
r.srs_startup_time = srsu2ms(srs_get_system_startup_time());
793770

794-
#ifndef SRS_OSX
795771
if (true) {
796772
FILE* f = fopen("/proc/uptime", "r");
797773
if (f == NULL) {
@@ -820,43 +796,6 @@ void srs_update_platform_info()
820796

821797
fclose(f);
822798
}
823-
#else
824-
// man 3 sysctl
825-
if (true) {
826-
struct timeval tv;
827-
size_t len = sizeof(timeval);
828-
829-
int mib[2];
830-
mib[0] = CTL_KERN;
831-
mib[1] = KERN_BOOTTIME;
832-
if (sysctl(mib, 2, &tv, &len, NULL, 0) < 0) {
833-
srs_warn("sysctl boottime failed, ignore");
834-
return;
835-
}
836-
837-
time_t bsec = tv.tv_sec;
838-
time_t csec = ::time(NULL);
839-
r.os_uptime = difftime(csec, bsec);
840-
}
841-
842-
// man 3 sysctl
843-
if (true) {
844-
struct loadavg la;
845-
size_t len = sizeof(loadavg);
846-
847-
int mib[2];
848-
mib[0] = CTL_VM;
849-
mib[1] = VM_LOADAVG;
850-
if (sysctl(mib, 2, &la, &len, NULL, 0) < 0) {
851-
srs_warn("sysctl loadavg failed, ignore");
852-
return;
853-
}
854-
855-
r.load_one_minutes = (double)la.ldavg[0] / la.fscale;
856-
r.load_five_minutes = (double)la.ldavg[1] / la.fscale;
857-
r.load_fifteen_minutes = (double)la.ldavg[2] / la.fscale;
858-
}
859-
#endif
860799

861800
r.ok = true;
862801
}
@@ -903,7 +842,6 @@ int srs_get_network_devices_count()
903842

904843
void srs_update_network_devices()
905844
{
906-
#ifndef SRS_OSX
907845
if (true) {
908846
FILE* f = fopen("/proc/net/dev", "r");
909847
if (f == NULL) {
@@ -940,9 +878,6 @@ void srs_update_network_devices()
940878

941879
fclose(f);
942880
}
943-
#else
944-
// TODO: FIXME: impelments it.
945-
#endif
946881
}
947882

948883
SrsNetworkRtmpServer::SrsNetworkRtmpServer()
@@ -990,7 +925,6 @@ void srs_update_rtmp_server(int nb_conn, SrsKbps* kbps)
990925
int nb_tcp_mem = 0;
991926
int nb_udp4 = 0;
992927

993-
#ifndef SRS_OSX
994928
if (true) {
995929
FILE* f = fopen("/proc/net/sockstat", "r");
996930
if (f == NULL) {
@@ -1020,20 +954,9 @@ void srs_update_rtmp_server(int nb_conn, SrsKbps* kbps)
1020954

1021955
fclose(f);
1022956
}
1023-
#else
1024-
// TODO: FIXME: impelments it.
1025-
nb_socks = 0;
1026-
nb_tcp4_hashed = 0;
1027-
nb_tcp_orphans = 0;
1028-
nb_tcp_tws = 0;
1029-
nb_tcp_total = 0;
1030-
nb_tcp_mem = 0;
1031-
nb_udp4 = 0;
1032-
#endif
1033957

1034958
int nb_tcp_estab = 0;
1035959

1036-
#ifndef SRS_OSX
1037960
if (true) {
1038961
FILE* f = fopen("/proc/net/snmp", "r");
1039962
if (f == NULL) {
@@ -1063,10 +986,7 @@ void srs_update_rtmp_server(int nb_conn, SrsKbps* kbps)
1063986

1064987
fclose(f);
1065988
}
1066-
#else
1067-
// TODO: FIXME: impelments it.
1068-
#endif
1069-
989+
1070990
// @see: https://github.com/shemminger/iproute2/blob/master/misc/ss.c
1071991
// TODO: FIXME: ignore the slabstat, @see: get_slabstat()
1072992
if (true) {

trunk/src/main/srs_main_server.cpp

+2-13
Original file line numberDiff line numberDiff line change
@@ -236,16 +236,6 @@ void show_macro_features()
236236
if (true) {
237237
stringstream ss;
238238
ss << "SRS on ";
239-
#ifdef SRS_OSX
240-
ss << "OSX";
241-
#endif
242-
#ifdef SRS_PI
243-
ss << "RespberryPi";
244-
#endif
245-
#ifdef SRS_CUBIE
246-
ss << "CubieBoard";
247-
#endif
248-
249239
#if defined(__amd64__)
250240
ss << " amd64";
251241
#endif
@@ -258,9 +248,8 @@ void show_macro_features()
258248
#if defined(__arm__)
259249
ss << "arm";
260250
#endif
261-
262-
#ifndef SRS_OSX
263-
ss << ", glibc" << (int)__GLIBC__ << "." << (int)__GLIBC_MINOR__;
251+
#if defined(__aarch64__)
252+
ss << " aarch64";
264253
#endif
265254

266255
ss << ", conf:" << _srs_config->config() << ", limit:" << _srs_config->get_max_connections()

trunk/src/utest/srs_utest.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -46,23 +46,18 @@ ISrsThreadContext* _srs_context = new ISrsThreadContext();
4646
SrsConfig* _srs_config = NULL;
4747
SrsServer* _srs_server = NULL;
4848

49-
// Disable coroutine test for OSX.
50-
#if !defined(SRS_OSX)
5149
#include <srs_app_st.hpp>
52-
#endif
5350

5451
// Initialize global settings.
5552
srs_error_t prepare_main() {
5653
srs_error_t err = srs_success;
5754

58-
#if !defined(SRS_OSX)
5955
if ((err = srs_st_init()) != srs_success) {
6056
return srs_error_wrap(err, "init st");
6157
}
6258

6359
srs_freep(_srs_context);
6460
_srs_context = new SrsThreadContext();
65-
#endif
6661

6762
return err;
6863
}

trunk/src/utest/srs_utest_app.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ using namespace std;
2727
#include <srs_kernel_error.hpp>
2828
#include <srs_app_fragment.hpp>
2929

30-
// Disable coroutine test for OSX.
31-
#if !defined(SRS_OSX)
32-
3330
#include <srs_app_st.hpp>
3431

3532
VOID TEST(AppCoroutineTest, Dummy)
@@ -375,5 +372,3 @@ VOID TEST(AppFragmentTest, CheckDuration)
375372
}
376373
}
377374

378-
#endif
379-

0 commit comments

Comments
 (0)