Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TimeConstraintTest on getPosition() #23

Closed
theod opened this issue Feb 5, 2016 · 2 comments
Closed

fix TimeConstraintTest on getPosition() #23

theod opened this issue Feb 5, 2016 · 2 comments
Assignees
Milestone

Comments

@theod
Copy link
Member

theod commented Feb 5, 2016

there is a test that doesn't pass :

QVERIFY(constraint->getPosition() == 0.25);

because the position is not updated when setting up the durations (nominal, min and max).
but this is also raising a confusion on what should be the position : does it supposed to be relative to nominal or max duration ?

@theod theod added this to the release/1.0 milestone Feb 5, 2016
@theod theod self-assigned this Feb 5, 2016
@jcelerier
Copy link
Member

but this is also raising a confusion on what should be the position : does it supposed to be relative to nominal or max duration ?

for me it should be relative to nominal duration : else with infinite max it would not work.

@jcelerier
Copy link
Member

let's reopen the issue if there is a problem with the current behaviour at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: TODO
Development

No branches or pull requests

2 participants