Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update value type when i-score changes it" commit #13

Closed
theod opened this issue Dec 17, 2015 · 2 comments
Closed

Revert "update value type when i-score changes it" commit #13

theod opened this issue Dec 17, 2015 · 2 comments
Assignees
Milestone

Comments

@theod
Copy link
Member

theod commented Dec 17, 2015

after some discussions with @jcelerier it seems this commit was a way to quickly solve a high level feature in i-score.

here the use case : if you declare an OSC parameter into the device explorer and then you start to write a scenario and then you realize that you need to change the type of the parameter all what have been written needs to be updated.

IHMO this an i-score issue and the API should keep strong typed Address as typing an Address is part of the specification of the ressources a scenario drive. It is like in C if you declare a int and start to code something and then you realize you need a string you'll need to review all the code to update the use of the variable. in most of the IDE you are assisted into this task so i-score should provides such high level feature to help users to update a scenario consider an Address type change.

@theod
Copy link
Member Author

theod commented Dec 17, 2015

here is the commit to revert abcdb2a

@theod theod changed the title Revert https://github.com/OSSIA/API/commit/abcdb2ae7b2c98b81480e29e383fb6d7936fca67 Revert "update value type when i-score changes it" commit Dec 17, 2015
@theod theod self-assigned this Dec 17, 2015
@theod theod added this to the release/1.0 milestone Feb 5, 2016
@jcelerier
Copy link
Member

this has been reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants