Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaRC input file DATA_OFFSET and DATA_SCALE may cause errors #69

Open
ossama-othman opened this issue Jan 17, 2018 · 0 comments
Open

MaRC input file DATA_OFFSET and DATA_SCALE may cause errors #69

ossama-othman opened this issue Jan 17, 2018 · 0 comments
Labels

Comments

@ossama-othman
Copy link
Owner

The MaRC input file DATA_OFFSET and DATA_SCALE keywords are not well tested in how they interact with some of the automatic scaling that MaRC performs, such as the automatic virtual image data scaling for integer typed maps. Setting either of these values will cause MaRC to set the FITS BZERO and/or BSCALE keywords in the FITS file, which will in turn cause underlying FITS library (CFITSIO) to scale the data accordingly.

At the very least, MaRC should disable CFITSIO's automatic scaling as it already does for its virtual images. However, that's simply a work around for a design issue in MaRC. Deprecating the MaRC input file DATA_OFFSET and DATA_SCALE keyword support in favor of pulling the corresponding values from the source image FITS files and automatically determining if they can be used seems like a better way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant