Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Upgrade markupsafe to version 1.1.0 #7780

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Nov 1, 2023

When Python inspector 0.9.8 and above analyzes a project containing markupsafe version 1.0.0 as dependency (with option --analyze-setup-py-insecurely), then it crashes for unknown reason, see also [1]. Upgrading markupsafe to 1.1.0 works around that issue. Do so, in order to prepare for upgrading Python inspector.

[1] aboutcode-org/python-inspector#133

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73e5110) 67.84% compared to head (6f659bd) 67.84%.
Report is 1 commits behind head on main.

❗ Current head 6f659bd differs from pull request most recent head 48e81b1. Consider uploading reports for the commit 48e81b1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7780   +/-   ##
=========================================
  Coverage     67.84%   67.84%           
  Complexity     2045     2045           
=========================================
  Files           357      357           
  Lines         16770    16770           
  Branches       2378     2378           
=========================================
  Hits          11378    11378           
  Misses         4402     4402           
  Partials        990      990           
Flag Coverage Δ
funTest-docker 65.79% <ø> (ø)
funTest-non-docker 36.16% <ø> (ø)
test 35.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau fviernau force-pushed the python-inspector-upgrade-prep branch from f9dccd1 to 45dd1d8 Compare November 1, 2023 12:21
@fviernau fviernau requested a review from sschuberth November 1, 2023 12:21
When Python inspector 0.9.8 and above analyzes a project containing
`markupsafe` version 1.0.0 as dependency (with option
`--analyze-setup-py-insecurely`), then it crashes for unknown reason,
see also [1]. Upgrading `markupsafe` to 1.1.0 works around that issue.
Do so, in order to prepare for upgrading Python inspector.

[1] aboutcode-org/python-inspector#133

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau force-pushed the python-inspector-upgrade-prep branch 2 times, most recently from 6f659bd to 48e81b1 Compare November 1, 2023 21:05
@fviernau fviernau requested a review from sschuberth November 1, 2023 21:06
@fviernau fviernau enabled auto-merge (rebase) November 1, 2023 21:06
@fviernau fviernau merged commit 9da44a3 into main Nov 1, 2023
22 checks passed
@fviernau fviernau deleted the python-inspector-upgrade-prep branch November 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants