Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport double sided material spec #418

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Backport double sided material spec #418

merged 5 commits into from
Dec 15, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 17, 2020

backport of pull request #410

* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 17, 2020
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #418 (0f0ef96) into sdf9 (a0d4807) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             sdf9     #418      +/-   ##
==========================================
+ Coverage   86.42%   86.43%   +0.01%     
==========================================
  Files          60       60              
  Lines        9294     9304      +10     
==========================================
+ Hits         8032     8042      +10     
  Misses       1262     1262              
Impacted Files Coverage Δ
src/Material.cc 98.07% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d4807...0f0ef96. Read the comment docs.

@scpeters
Copy link
Member

some odd windows test failures after merging with sdf9:

1: [----------] 2 tests from DOMActor
1: [ RUN      ] DOMActor.LoadActors
  1/172 Test   #1: INTEGRATION_actor_dom ..................................Exit code 0xc0000417
***Exception:   0.09 sec
35: [----------] 1 test from DOMWorld
35: [ RUN      ] DOMWorld.LoadLights
 35/172 Test  #35: INTEGRATION_light_dom ..................................Exit code 0xc0000417
***Exception:   0.08 sec
81: [----------] 5 tests from DOMWorld
81: [ RUN      ] DOMWorld.NoName
81: No HOME defined in the environment. Will not log.
81: [       OK ] DOMWorld.NoName (47 ms)
81: [ RUN      ] DOMWorld.Duplicate
81: [       OK ] DOMWorld.Duplicate (59 ms)
81: [ RUN      ] DOMWorld.LoadIncorrectElement
81: [       OK ] DOMWorld.LoadIncorrectElement (62 ms)
81: [ RUN      ] DOMWorld.Load
 81/172 Test  #81: INTEGRATION_world_dom ..................................Exit code 0xc0000417
***Exception:   0.24 sec
85: [----------] 7 tests from DOMActor
85: [ RUN      ] DOMActor.DefaultConstruction
85: [       OK ] DOMActor.DefaultConstruction (0 ms)
85: [ RUN      ] DOMActor.CopyConstructor
85: [       OK ] DOMActor.CopyConstructor (0 ms)
85: [ RUN      ] DOMActor.CopyAssignmentOperator
85: [       OK ] DOMActor.CopyAssignmentOperator (0 ms)
85: [ RUN      ] DOMActor.MoveConstructor
85: [       OK ] DOMActor.MoveConstructor (0 ms)
85: [ RUN      ] DOMActor.MoveAssignment
85: [       OK ] DOMActor.MoveAssignment (0 ms)
85: [ RUN      ] DOMActor.CopyAssignmentAfterMove
85: [       OK ] DOMActor.CopyAssignmentAfterMove (0 ms)
85: [ RUN      ] DOMActor.Add
 85/172 Test  #85: UNIT_Actor_TEST ........................................Exit code 0xc0000417
***Exception:   0.03 sec

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@scpeters
Copy link
Member

now the windows build is failing with an internal compiler error:

I'm going to take that build machine offline and try again

@scpeters
Copy link
Member

@osrf-jenkins run tests please

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters merged commit 66d934f into sdf9 Dec 15, 2020
@scpeters scpeters deleted the double_sided_material_9 branch December 15, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants