Enforce minimum/maximum values specified in SDFormat description files (Retry PR) #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf10 #303 +/- ##
==========================================
+ Coverage 86.66% 86.83% +0.17%
==========================================
Files 59 59
Lines 9071 9138 +67
==========================================
+ Hits 7861 7935 +74
+ Misses 1210 1203 -7
Continue to review full report at Codecov.
|
Signed-off-by: Steve Peters <[email protected]>
scpeters
approved these changes
Jun 24, 2020
|
I would add something to the Migration guide about this, and the changelog as well |
Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…s (Retry PR) (gazebosim#303) Currently, some SDFormat description files contain min and max values, but the parser does not enforce those values in any way. This PR adds a validation step in the parser that checks if scalar values are within the allowed range. Note that this PR addresses only element values, not attributes.
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…s (Retry PR) (gazebosim#303) Currently, some SDFormat description files contain min and max values, but the parser does not enforce those values in any way. This PR adds a validation step in the parser that checks if scalar values are within the allowed range. Note that this PR addresses only element values, not attributes. Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Jul 2, 2020
…s (Retry PR) (#303) Currently, some SDFormat description files contain min and max values, but the parser does not enforce those values in any way. This PR adds a validation step in the parser that checks if scalar values are within the allowed range. Note that this PR addresses only element values, not attributes. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some SDFormat description files contain min and max values, but the parser does not enforce those values in any way. This PR adds a validation step in the parser that checks if scalar values are within the allowed range. Note that this PR addresses only element values, not attributes.
Toward #260.
This is a retry of #259.