Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterization at startup #113

Closed
7 tasks done
mabelzhang opened this issue Jan 12, 2023 · 2 comments · Fixed by #125 or #133
Closed
7 tasks done

Parameterization at startup #113

mabelzhang opened this issue Jan 12, 2023 · 2 comments · Fixed by #125 or #133
Assignees

Comments

@mabelzhang
Copy link
Collaborator

mabelzhang commented Jan 12, 2023

Offer a simple and obvious way to allow the user to specify a number of parameters at start-up.

Things to parameterize:

Workflow

Implementation options:

  • SDF (currently generated at build time)
  • Launch file parameter (if just a few)
  • YAML file, which can handle arrays
@andermi
Copy link
Collaborator

andermi commented Jan 19, 2023

@hamilton8415 is the scale factor something to set for an entire run or more like the gain scheduler sending a scale factor to refresh the command timeout? Or even exactly like the gain scheduler sending various scale factors over a period of time?

@hamilton8415
Copy link
Collaborator

hamilton8415 commented Jan 19, 2023

It works a few ways, the scale factor is a multiplier to the built in damping coefficient in the power-take off device. In most simulation cases I think the usual pattern would be to set a scale factor at start-up, and collect the results for a 10-15 minute sample period. It is possible to change the scale-factor during runs using the pbcmd "scale" command. Same command on the buoy and also the simulator.... Finally, we do have an application we often run on the buoy that is changing the scale factor every 30 minutes or so based on measurements from a local wave-height measurement buoy. @andermi can comment further, but I believe that is ros2 application that uses the ros2 services, and that Michael actually used an early version of this simulator before it was deployed on the buoy earlier this summer.

@mabelzhang mabelzhang mentioned this issue Jan 23, 2023
5 tasks
@andermi andermi linked a pull request Jan 24, 2023 that will close this issue
@mabelzhang mabelzhang reopened this Feb 6, 2023
@andermi andermi closed this as completed Mar 6, 2023
@mabelzhang mabelzhang linked a pull request Mar 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants