Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject NL objectives in MOI wrapper #128

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

goulart-paul
Copy link

The MOI wrapper should reject objective functions that are nonlinear. I have implemented a check that will only allow models with attributes that MOI interface knows how to deal with, which implicitly rejects NLPblock etc.

Fixes the issue raised in https://github.com/orgs/osqp/discussions/706 by reporting the problem unsolvable.

Additional fix to remove regex warnings in the MOI wrapper test.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

r"test_unbounded_MAX_SENSE$",
r"test_unbounded_MAX_SENSE_offset$",
r"^test_unbounded_MIN_SENSE$",
r"test_unbounded_MIN_SENSE_offset$",
# FIXME
"test_model_copy_to_UnsupportedAttribute",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be fixed now?

Copy link
Author

@goulart-paul goulart-paul Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like quite a few of the disabled tests are passing now. I have reenabled those that pass on my local machine. If they also pass CI checks that probably OK to bring them back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants