Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Unfork] switch fork to cosmossdk.io/math #6099

Closed
Tracked by #5724
p0mvn opened this issue Aug 17, 2023 · 0 comments · Fixed by #6270
Closed
Tracked by #5724

[SDK Unfork] switch fork to cosmossdk.io/math #6099

p0mvn opened this issue Aug 17, 2023 · 0 comments · Fixed by #6270
Assignees

Comments

@p0mvn
Copy link
Member

p0mvn commented Aug 17, 2023

Background

Prior to being able to replace all usage of sdk.Dec and sdk.Int with respective sdkmath types in Osmosis, we need to make sure that our fork is updated.

Suggested Design

Follow history: https://github.com/cosmos/cosmos-sdk/commits/main?after=09db6997c532e984905b33f8618b57b2bbd1fed1+34&branch=main&path%5B%5D=math&qualified_name=refs%2Fheads%2Fmain

  1. Create type alias for Int and Uint, delete in-repo implementations, ref: refactor!: create math go sub module cosmos/cosmos-sdk#11788
  2. Create type alias for Dec, delete in -repo implementations, ref: refactor: Move sdk.Dec to math package cosmos/cosmos-sdk#12634

Acceptance Criteria

  • fork is fully switched to sdkmath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant