Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set incentive gauge weight to 0 #546

Closed
UnityChaos opened this issue Oct 22, 2021 · 0 comments · Fixed by #563
Closed

Cannot set incentive gauge weight to 0 #546

UnityChaos opened this issue Oct 22, 2021 · 0 comments · Fixed by #563
Assignees

Comments

@UnityChaos
Copy link
Member

The validation checks for gauge weights in an update-pool-incentives proposal are required to be positive. This makes setting a gauge to 0 weight impossible. Should be changed to positive or zero.

func (r DistrRecord) ValidateBasic() error {
if !r.Weight.IsPositive() {
return ErrDistrRecordNotPositiveWeight

(Unless there's some way to propose deleting a gauge rather than setting it to zero I'm unaware of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants