-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fast node cache and benchmark #1041
Comments
|
Comparison:
Clearly, having cache in |
science! that is why it's called a lab <3 Btw, nice benchmarks sir |
It is surprising to me that the decrease in performance affected only Our initial guess was that the cache in
I did the pprof of According to pprof, From pprof, we also see that there are calls to At this point, it is unclear to me why I can't observe cache being utilized in I am going to pause the work on this issue since the scope has changed. I will come back to it when I'm working on osmosis-labs/iavl#32 which is about investigating goleveldb configs. Once I understand some My branch with no fast cache in node db: The
I can see in the defaults that the |
I created a manual test where I set only 2 keys i.e.:
Then, to simulate the
Contrary to the pprof results from the benchmark, it went to the in-memory db within goleveldb . |
This issue is resolved, reconfigured fast cache to a smaller value |
Background
We suspect that fastNodeCache in
nodeDb
may not be very useful. We should attempt to remove it and benchmark the resultsAcceptance Criteria
fastNodeCache
fromnodeDb
The text was updated successfully, but these errors were encountered: