Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pool Modal for Concentrated Liquidity [500 USDC Reward!] #2727

Closed
MaxMillington opened this issue Jan 24, 2024 · 14 comments
Closed

Create Pool Modal for Concentrated Liquidity [500 USDC Reward!] #2727

MaxMillington opened this issue Jan 24, 2024 · 14 comments
Labels
Bounty Anyone who can ship a fix to these issues will be awarded OSMO as a thank you!

Comments

@MaxMillington
Copy link
Collaborator

πŸ› Bug Bounty: Fix Needed! πŸ› οΈ
Reward: πŸ† 500 USDC πŸ†

We are excited to announce a bug bounty for third-party developers! If you've got the skills and know-how, here's your chance to earn some πŸ’Έ and contribute to our project.

Issue Description πŸ“„

Add modal for creating a pool for concentrated liquidity

Expected Behavior πŸ’‘

As a user, when I click in to create a pool, I should see an experience as in the below figma file.

Link to Designs
Password: Wosmongton2024

Screenshot 2024-01-24 at 10 54 24 AM

Requirements for the Bounty 🏁

Submit a pull request with a verified fix to the issue.
The fix should not introduce any new bugs or vulnerabilities.
Code should follow our project's style and contribution guidelines.
Your solution will be reviewed by our team, and the bounty will be awarded upon approval.
How to Claim Your Bounty πŸ’°

Fork our repository.
Create a new branch for your fix.
Submit a pull request to our main branch.
Include detailed information about your fix and how it addresses the issue.

Once reviewed and merged, the 500 USDC will be transferred to your wallet.
We look forward to your contributions and thank you for helping improve our project!

Please Note: All bounty claimants must undergo a KYC (Know Your Customer) process with our finance team to receive the reward. This is a mandatory step to ensure compliance with financial regulations.

PLEASE ALLOW 1 MONTH FOR PAYMENT TO BE RENDERED.

@MaxMillington MaxMillington added the Bounty Anyone who can ship a fix to these issues will be awarded OSMO as a thank you! label Jan 24, 2024
@ChetanKarwa
Copy link

ChetanKarwa commented Jan 25, 2024

Hey Max, I would like to work on this.
I also started working on this, but still, I was not able to get much ahead with creating the pool.
Stuck at the first step because the config on creating a new poll gives no assets.
Can you please help me out with how can I get some dummy data?

Thank you

@MaxMillington
Copy link
Collaborator Author

@ChetanKarwa

Thanks for starting work!

I'm not quite sure I understand the difficulty however, you should be able to follow the readme and run yarn build && yarn dev to run either the app on mainnet, or the app on testnet. You shouldn't need dummy data to run the app.

@ChetanKarwa
Copy link

Not sure if this is very naive question or not.

I started the app successfully on dev but was stuck here.
So In testnet I'm getting this error.
image
Else I am stuck here without info:
image

@MaxMillington
Copy link
Collaborator Author

@ChetanKarwa in this case, I would recommend stubbing the actual create pools call, since implementing the attached designs shouldn't require any changes to that call (i.e. you can assume it works)

@ChetanKarwa
Copy link

Hey Max, Sorry to bother you again. I have created designs for modal. Just needed details in design.

  • How does the dropdown of select token open up
  • How does the dropdown of swap fee open up and what is the range of possible swap fee

Also, I was not able to get on how to stub the API. If I could connect with you or someone else to get proper detail on how should it work with apis. I would integrate it with APIs and create a PR for the same.

@MaxMillington
Copy link
Collaborator Author

@ChetanKarwa both dropdowns should be triggered by a click, like a normal dropdown. The swap fees should be pulled from the Concentrated Liquidity modules params. If you query the CL modules params they will show up.

@ChetanKarwa
Copy link

I wanted to know if the default drop-down of html would be fine or should I design items in dropdown

@MaxMillington
Copy link
Collaborator Author

@ChetanKarwa you can follow the designs used in other dropdowns in the app

@aliraza556
Copy link

Hi @MaxMillington,
This issue is available?

@MaxMillington
Copy link
Collaborator Author

@aliraza556 Still available

@aliraza556
Copy link

Assign me

@MaxMillington
Copy link
Collaborator Author

@aliraza556 no need to be assigned. We award the bounty to the first person to merge a fix.

@fabryscript
Copy link
Collaborator

fabryscript commented Jul 4, 2024

Almost implemented here with some small TODOs: #3452
cc @MaxMillington

@MaxMillington
Copy link
Collaborator Author

thank you @fabryscript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Anyone who can ship a fix to these issues will be awarded OSMO as a thank you!
Projects
None yet
Development

No branches or pull requests

4 participants