Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for resources and documentation. #638

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Conversation

gravitystorm
Copy link
Contributor

I noticed today on openstreetmap.org that some chapter links were not using https, so I made some investigations. This PR updates all of the resources and documentation that used http to use https, where:

There were two resources that I didn't update, since they need further investigation:

  • resources/africa/nigeria/ym-Federal-University-of-Technology-Akure.json:9: "url": "http://spaceclubfuta.com.ng/" - domain not found
  • resources/asia/bangladesh/ym-Asian-University-for-Women.json:9: "url": "http://www.auw.edu.bd/" - no redirect, but some kind of in-browser redirect to a completely different domain.

These two could be addressed separately.

In addition, there is some json-schema-related files that I haven't changed either, they could again be addressed separately.

Refs #533

The http versions responded today with 301 or 302 status codes to the corresponding
https version, or in the case of the bit.ly link, had the same target page for both.
The http versions responded with 301 redirects to the https version.
@kmpoppe
Copy link
Collaborator

kmpoppe commented Feb 12, 2023

Just shy of a month later, three of the sites that you changed do no yield any meaningful information anymore:

resources/africa/guinea/ym-General-Lansana-Conte-University.json
resources/africa/south_africa/ym-University-of-Pretoria.json
resources/north-america/united_states/ym-University-of-Oregon.json

All pages have a "contact" person, do you want to send mails to them @gravitystorm Andy? I will merge your changes anyway, there's no use in waiting for any kind of response from them. More changes can be worked on with a new PR.

@kmpoppe kmpoppe merged commit 33e5a0d into osmlab:main Feb 12, 2023
@gravitystorm
Copy link
Contributor Author

@kmpoppe - thank you for merging! I don't have any plans to follow up on the sites that aren't responsive, I was just focussed on the http/https related changes for our downstream usage.

@kmpoppe
Copy link
Collaborator

kmpoppe commented Feb 13, 2023

Okay thanks. Btw, @gravitystorm, do you have a script at hand that could check all URLs for 4xx/5xx responses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants