Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink #440

Merged
merged 11 commits into from
Apr 9, 2021
Merged

Permalink #440

merged 11 commits into from
Apr 9, 2021

Conversation

kmpoppe
Copy link
Collaborator

@kmpoppe kmpoppe commented Apr 5, 2021

Resolves #393

@bhousel I hope you don't mind my quite radical moving around code in the index.html to make this work :)

^Kai

@kmpoppe kmpoppe added the openstreetmap.community An issue or enhancement for the preview website label Apr 5, 2021
@kmpoppe kmpoppe requested a review from bhousel April 5, 2021 04:45
@kmpoppe kmpoppe self-assigned this Apr 5, 2021
Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok overall - I'd stick to ES5 JavaScript to keep it working in old browsers. You can merge it if you want!

docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@kmpoppe
Copy link
Collaborator Author

kmpoppe commented Apr 7, 2021

@bhousel was the ES5 reference just a hint or did I change something that's not ES5 compatible? I had thought not, because I just moved some code around and used the methods that where already available through the map object?
Forget it ... You commented inline in the code... Why didn't GitHub tell me? Argh! Will change according to your comments!

^Kai

docs/index.html Outdated Show resolved Hide resolved
const => var for ES5 compatibility
docs/index.html Outdated Show resolved Hide resolved
=> to function() for ES5 compatibility
docs/index.html Outdated Show resolved Hide resolved
=> to function() for ES5 compatibility
@kmpoppe kmpoppe merged commit 2dc57b2 into osmlab:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openstreetmap.community An issue or enhancement for the preview website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to link specific territory
2 participants