Correct region of UK local chapter #411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSM Local Chapter covers England, Scotland, Wales, Northern Ireland, the Channel Islands and Isle of Man. This change better reflects the region and has been tested on the Location Conflation test site:
The change:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB-ENG%22%2C%20%22GB-NIR%22%2C%20%22GB-SCT%22%2C%20%22GB-WLS%22%2C%20%22JE%22%2C%20%22GG%22%2C%20%22IM%22%5D%7D
Note that this is the same as ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "830", "833"] but I have used ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "JE", "GG", "IM"] rather than mixing ISO alpha codes with UN M49 numbers.
The original:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB%22%5D%7D%0A
FWIW the region shown for ISO code GB is likely to be incorrect. The ISO website describes it (https://www.iso.org/obp/ui/#iso:code:3166:GB) as "the United Kingdom of Great Britain and Northern Ireland". It is not including the Crown Dependencies or the British Overseas Territories and all of these have their own ISO codes such as IM for Ilse of Man and IO for the British Indian Ocean Territory. When the OSM UK organisation was founded we decided to include the Crown Dependencies given their close proximity to mainland Great Britain as set out in our Articles of Association (https://osmuk.org/wp-content/uploads/2016/12/UKOSM_Articles.pdf).
https://en.wikipedia.org/wiki/United_Kingdom#Dependencies
Related alternate change is rapideditor/country-coder#35