Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct region of UK local chapter #411

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Correct region of UK local chapter #411

merged 2 commits into from
Jan 29, 2021

Conversation

RobJN
Copy link
Contributor

@RobJN RobJN commented Jan 28, 2021

The OSM Local Chapter covers England, Scotland, Wales, Northern Ireland, the Channel Islands and Isle of Man. This change better reflects the region and has been tested on the Location Conflation test site:

The change:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB-ENG%22%2C%20%22GB-NIR%22%2C%20%22GB-SCT%22%2C%20%22GB-WLS%22%2C%20%22JE%22%2C%20%22GG%22%2C%20%22IM%22%5D%7D

Note that this is the same as ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "830", "833"] but I have used ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "JE", "GG", "IM"] rather than mixing ISO alpha codes with UN M49 numbers.

The original:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB%22%5D%7D%0A

FWIW the region shown for ISO code GB is likely to be incorrect. The ISO website describes it (https://www.iso.org/obp/ui/#iso:code:3166:GB) as "the United Kingdom of Great Britain and Northern Ireland". It is not including the Crown Dependencies or the British Overseas Territories and all of these have their own ISO codes such as IM for Ilse of Man and IO for the British Indian Ocean Territory. When the OSM UK organisation was founded we decided to include the Crown Dependencies given their close proximity to mainland Great Britain as set out in our Articles of Association (https://osmuk.org/wp-content/uploads/2016/12/UKOSM_Articles.pdf).
https://en.wikipedia.org/wiki/United_Kingdom#Dependencies

Related alternate change is rapideditor/country-coder#35

The OSM Local Chapter covers England, Scotland, Wales, Northern Ireland, the Channel Islands and Isle of Man. This change better reflects the region and has been tested on the Location Conflation test site:

The change:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB-ENG%22%2C%20%22GB-NIR%22%2C%20%22GB-SCT%22%2C%20%22GB-WLS%22%2C%20%22JE%22%2C%20%22GG%22%2C%20%22IM%22%5D%7D

Note that this is the same as ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "830", "833"] but I have used ["GB-ENG", "GB-NIR", "GB-SCT", "GB-WLS", "JE", "GG", "IM"] rather than mixing ISO alpha codes with UN M49 numbers.

The original:
https://ideditor.github.io/location-conflation/?locationSet=%7B%20include%3A%20%5B%22GB%22%5D%7D%0A

FWIW the region shown for ISO code GB is likely to be incorrect. The ISO website describes it (https://www.iso.org/obp/ui/#iso:code:3166:GB) as "the United Kingdom of Great Britain and Northern Ireland". It is not including the Crown Dependencies or the British Overseas Territories and all of these have their own ISO codes such as IM for Ilse of Man and IO for the British Indian Ocean Territory. When the OSM UK organisation was founded we decided to include the Crown Dependencies given their close proximity to mainland Great Britain as set out in our Articles of Association (https://osmuk.org/wp-content/uploads/2016/12/UKOSM_Articles.pdf).
https://en.wikipedia.org/wiki/United_Kingdom#Dependencies
@bhousel
Copy link
Member

bhousel commented Jan 29, 2021

Thanks @RobJN 👍

Not sure whether this is helpful, but I also built https://ideditor.codes/ so that people can see and play around with what values country-coder makes available.

rather than mixing ISO alpha codes with UN M49 numbers.

It's ok to mix different identifiers, location-conflation can handle it. In fact fewer is better (there is a slight performance penalty as location-conflation unions the polygons together, but this really doesn't matter much in practice). So you might even be able to stick Q23666 in there to simplify things even more.

@bhousel bhousel merged commit 3bfd1a4 into osmlab:main Jan 29, 2021
@RobJN RobJN deleted the patch-3 branch January 30, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants