Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create osm-iraq-mailing-list #370

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Create osm-iraq-mailing-list #370

merged 1 commit into from
Sep 30, 2020

Conversation

lukaszkruk
Copy link
Contributor

adding the first iraq community

@bhousel
Copy link
Member

bhousel commented Sep 30, 2020

Thanks @lukaszkruk, and welcome 👋

@bhousel bhousel merged commit aaec889 into osmlab:main Sep 30, 2020
@lukaszkruk
Copy link
Contributor Author

Thanks @bhousel :)

I just made a tiny OSM edit with iD in Iraq hoping that the community added through this PR would pop up on the left-hand pane, but it does not. Should it be there, or am I missing something? Or was it simply not enough time for this to get included in iD?

Cheers!

image

@bhousel
Copy link
Member

bhousel commented Dec 15, 2020

Should it be there, or am I missing something? Or was it simply not enough time for this to get included in iD?

I don't know.. I included it in v2.1.2, so they should have it 🤷

@bhousel
Copy link
Member

bhousel commented Dec 15, 2020

Just looked into it and the reason this never got brought in was because there's no .json extension on the file, so it was skipped.
I renamed the file in ff8e5a8

bhousel added a commit that referenced this pull request Dec 15, 2020
@lukaszkruk
Copy link
Contributor Author

Oops, thanks for the fix!

@bhousel
Copy link
Member

bhousel commented Dec 16, 2020

Oops, thanks for the fix!

No worries @lukaszkruk , there were a few other files like this too..
In 8d20f54 I added a check so we can catch if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants