Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isle of Man, Guernsey, and Jersey #333

Closed
jnicho02 opened this issue Feb 8, 2020 · 4 comments
Closed

Isle of Man, Guernsey, and Jersey #333

jnicho02 opened this issue Feb 8, 2020 · 4 comments

Comments

@jnicho02
Copy link
Contributor

jnicho02 commented Feb 8, 2020

Official area of coverage for what we call 'United Kingdom' is OSM is the https://en.wikipedia.org/wiki/British_Islands#/media/File:British_Islands.svg

I'm trying to include the Isle of Man, Guernsey, and Jersey in the OSMUK area, etc.

{
  "id": "uk-localchapter",
  "type": "osm-lc",
  "locationSet": {"include": ["gb", "gg", "je", "im"]},
  ...
}

but they don't appear to be creating geojson in /dist/combined.geojson either separately or in a combined gb feature.

Looking at the combined.geojson I think that GB territories are already being included in "iso1A2": "GB"

"members": ["680", "IO", "KY", "AI", "BM", "MS", "DG", "GS", "PN", **"JE"**, "SH", **"GG"**, "TA", "TC", **"IM"**, "FK", "VG", "GI", "AC"],

but the GB feature has 5 polygons, not including IM, JE, and GG

Pulling out just the GB Feature from combined.geojson (sorry github issues won't accept .geojson file extension)
gb.geojson.txt

I believe that countryCoder does have geojson for IM, JE, and GG.

@bhousel
Copy link
Member

bhousel commented Feb 10, 2020

I looked into this a bit today - It turns out to be this bug in location-conflation, which we use to merge the Country Coder polygons together.

rapideditor/location-conflation#4

@bhousel
Copy link
Member

bhousel commented Feb 13, 2020

I think this is fixed with the location-conflation update in df2eb55

Because the combined.geojson file in JSDelivr is cached for a while, this won't show up on https://openstreetmap.community/ right away, so I'll leave this open until it's confirmed fixed.

@bhousel
Copy link
Member

bhousel commented Feb 16, 2020

this won't show up on https://openstreetmap.community/ right away, so I'll leave this open until it's confirmed fixed.

Just checked today and it looks good 👍

@bhousel bhousel closed this as completed Feb 16, 2020
@jnicho02
Copy link
Contributor Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants