Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OSM India FB Page #28

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Adding OSM India FB Page #28

merged 2 commits into from
Mar 26, 2018

Conversation

jinalfoflia
Copy link
Contributor

@jinalfoflia jinalfoflia commented Mar 26, 2018

Adding the OpenStreetMap India Facebook Page

cc: @bhousel

Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks @jinalfoflia - just one minor change

"properties": {"name": "India"},
"geometry": {
"type": "MultiPolygon",
"coordinates": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like MultiPolygon needs an additional nesting of coordinate array rings (add [ )

[75.757061, 34.504923],
[76.871722, 34.653544],
[77.837451, 35.49401]
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and a ] here too!

@jinalfoflia
Copy link
Contributor Author

Thank you for looking into this @bhousel, have added the extra nesting for multipolygon. Let me know if there are any other changes, thank you.

@bhousel bhousel merged commit b5eb99a into osmlab:master Mar 26, 2018
@bhousel
Copy link
Member

bhousel commented Mar 26, 2018

Thanks @jinalfoflia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants