Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korea country code (and folder name) #205

Closed
jbelien opened this issue Jan 6, 2019 · 2 comments
Closed

Korea country code (and folder name) #205

jbelien opened this issue Jan 6, 2019 · 2 comments

Comments

@jbelien
Copy link
Contributor

jbelien commented Jan 6, 2019

I noticed while upgrading "OpenStreetMap Community Index Viewer" an issue with Korea.

They used the country code KO which doesn't seem to be a valid ISO code. It should be KR for South Korea or KP for North Korea.

In the same order of idea, I think we should use asia/south_korea instead of asia/korea for the folder name.

@jbelien jbelien changed the title Issue with Korea Korea country code (and folder name) Jan 6, 2019
@bhousel bhousel closed this as completed in e17710e Jan 6, 2019
@jbelien
Copy link
Contributor Author

jbelien commented Jan 6, 2019

Awesome, thanks a lot @bhousel ! :)

Just a quick notice: https://github.com/osmlab/osm-community-index/blob/master/features/asia/south_korea/south_korea.geojson is whole korea, not just south korea.

@bhousel
Copy link
Member

bhousel commented Jan 6, 2019

Just a quick notice: https://github.com/osmlab/osm-community-index/blob/master/features/asia/south_korea/south_korea.geojson is whole korea, not just south korea.

Whoops - thanks for catching this! I fixed in 1f2aa15 by splitting them into 2 files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants