Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store -> localStorage #126

Closed
starsep opened this issue Dec 25, 2023 · 1 comment
Closed

store -> localStorage #126

starsep opened this issue Dec 25, 2023 · 1 comment

Comments

@starsep
Copy link
Contributor

starsep commented Dec 25, 2023

I would like to suggest dropping store dependency and using localStorage directly.

Pros:

  • dropping dependency which had the latest release 7 years ago
  • smaller library size

Cons:

What do you think?
I can prepare PR if it makes sense

@bhousel
Copy link
Member

bhousel commented Jan 4, 2024

I agree , store seems pretty unnecessary these days.
I already have some wrapper code around localStorage in Rapid, I can just do the same thing here too.

@bhousel bhousel closed this as completed in 41f28a1 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants