Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tennessee state route shields have repetitive entries in legend #771

Closed
1ec5 opened this issue Feb 7, 2023 · 1 comment · Fixed by #773
Closed

Tennessee state route shields have repetitive entries in legend #771

1ec5 opened this issue Feb 7, 2023 · 1 comment · Fixed by #773
Labels
bug Something isn't working shields

Comments

@1ec5
Copy link
Member

1ec5 commented Feb 7, 2023

Tennessee’s primary and secondary state route shields have separate entries in the legend, but since these are two shields for the same network, Wikidata has only a single item associated with both network=US:TN:primary and network=US:TN:secondary, resulting in a redundant entry:

McMinnville

The legend should combine these rows into a single row with two shields on it, just as it does in other cases where there are multiple shields within the same shield definition.

@1ec5 1ec5 added bug Something isn't working shields labels Feb 7, 2023
@1ec5
Copy link
Member Author

1ec5 commented Feb 7, 2023

As a counterpoint, Puerto Rico similarly has multiple shields for the same network based on classification, but each classification has its own Wikidata item, such as for secondary roads. This would be a better long-term approach for providing more specific captions in each language, but combining the entries would be less silly in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shields
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant