-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coalesce special route networks in legend #660
Comments
Do you have an example? I found these, but they have black-on-white |
Yes, these are the ones I’m thinking of. They do call |
Ah. My mistake. I was comparing
I haven't managed to get a
I did get a shot with a county road whose township matches a neighboring county's main style. 😅 Ohio, what have you done!? |
Actually I meant this as an example of where we wouldn’t want to do any coalescing. The idea is that we wouldn’t insist on the creation of separate Wikidata items for |
That makes so much more sense. Thanks for your patience! |
The legend added in #632 has a “Route markers” section that lists special or “bannered” route networks separately from their parent route networks. In most cases, users wouldn’t consider the special routes to belong to a separate network and would find this presentation to be redundant.
Most American print maps omit the special routes entirely, but this project’s legend is intended to inform users who are less familiar with AASHTO route designations than the average American motorist. Some maps include an unobtrusive decoder ring for the abbreviations that appear in the banners:
To power a similar table, we’d first need to determine that a
network
value is a special route. One clue would be themodifiers
property thatbanneredShield()
adds to a shield definition object:https://github.com/ZeLonewolf/openstreetmap-americana/blob/820a1fe4c206c60cb32a12ea9ff83cef4be94e49/src/js/shield_defs.js#L969-L972
However, there are some tricky cases where we’ve called
banneredShield()
to distinguish two shields in the same region that otherwise look identical because of how we’ve drastically simplified the shields.The text was updated successfully, but these errors were encountered: