Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce special route networks in legend #660

Open
1ec5 opened this issue Jan 3, 2023 · 5 comments
Open

Coalesce special route networks in legend #660

1ec5 opened this issue Jan 3, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@1ec5
Copy link
Member

1ec5 commented Jan 3, 2023

The legend added in #632 has a “Route markers” section that lists special or “bannered” route networks separately from their parent route networks. In most cases, users wouldn’t consider the special routes to belong to a separate network and would find this presentation to be redundant.

Downingtown

Most American print maps omit the special routes entirely, but this project’s legend is intended to inform users who are less familiar with AASHTO route designations than the average American motorist. Some maps include an unobtrusive decoder ring for the abbreviations that appear in the banners:

Rand McNally 1993 Rand McNally

To power a similar table, we’d first need to determine that a network value is a special route. One clue would be the modifiers property that banneredShield() adds to a shield definition object:

https://github.com/ZeLonewolf/openstreetmap-americana/blob/820a1fe4c206c60cb32a12ea9ff83cef4be94e49/src/js/shield_defs.js#L969-L972

However, there are some tricky cases where we’ve called banneredShield() to distinguish two shields in the same region that otherwise look identical because of how we’ve drastically simplified the shields.

@1ec5 1ec5 added the enhancement New feature or request label Jan 3, 2023
@michaelblyons
Copy link
Contributor

However, there are some tricky cases where we’ve called banneredShield() to distinguish two shields in the same region that otherwise look identical because of how we’ve drastically simplified the shields.

Do you have an example? I found these, but they have black-on-white TWP-annotated and white-on-green with no annotation. It's not difficult to find two different networks' identical shields without annotation banners, but I don't know where to look for banneredShield() ones.

@1ec5
Copy link
Member Author

1ec5 commented Jan 5, 2023

I found these, but they have black-on-white TWP-annotated and white-on-green with no annotation.

Yes, these are the ones I’m thinking of. They do call banneredShield().

@michaelblyons
Copy link
Contributor

Yes, these are the ones I’m thinking of. They do call banneredShield().

Screen Shot 2023-01-05 at 12 09 18 PM

Ah. My mistake. I was comparing US:OH:LOG:Union to US:OH:LOG:Pleasant instead of comparing it to US:OH:LOG.
So ideally, we'd want this?

Text (For)
235 Ohio state routes US:OH
24 Logan County routes
Annotations: TWP
US:OH:LOG, US:OH:LOG:Miami, US:OH:LOG:Union
33 "Logan County routes"?
"Pleasant Township"?
Both?
US:OH:LOG:Pleasant

I haven't managed to get a TWP road in frame with an otherwise identical other-county road, which could look like any of these:

Text (For)
33 Foo County routes US:OH:FOO
TWP
24
Logan County routes US:OH:LOG:Union
Or
24 Logan County routes
Annotations: TWP
US:OH:LOG:Union
Or
TWP
24
Union Township routes US:OH:LOG:Union

I did get a shot with a county road whose township matches a neighboring county's main style. 😅 Ohio, what have you done!?

Screen Shot 2023-01-05 at 12 32 15 PM

@1ec5
Copy link
Member Author

1ec5 commented Jan 5, 2023

Actually I meant this as an example of where we wouldn’t want to do any coalescing. The idea is that we wouldn’t insist on the creation of separate Wikidata items for US:US:Truck, US:OH:Business, etc., because we can tell that they’re the same as US:US and US:OH, respectively, with the addition of a banner on top. This gets complicated because it would result in the “Logan County routes” entry saying “Abbreviations: TWP = Union”.

@michaelblyons
Copy link
Contributor

That makes so much more sense. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants