Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): adding python coc option #222

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Anavelyz
Copy link
Collaborator

Pull Request description

Adding the Python Code of Conduct option as an option in the template.

Edited files:

  • src/scicookie/cookiecutter.json
  • src/scicookie/hooks/post_gen_project.py
  • src/scicookie/profiles/base.yaml
  • src/scicookie/profiles/osl.yaml
  • tests/smoke/files.sh

New files:
src/scicookie/{{cookiecutter.project_slug}}/coc/PYTHON_ADAPTED_COC.md

Solve #143

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved

@Anavelyz Anavelyz marked this pull request as ready for review February 28, 2024 19:50
@Anavelyz Anavelyz requested a review from xmnlab February 28, 2024 19:50
@xmnlab
Copy link
Member

xmnlab commented Feb 29, 2024

@Anavelyz could you rebase your branch on top of the main upstream branch please?

@Anavelyz Anavelyz force-pushed the 143-python-coc-support branch from e6db788 to 4131401 Compare February 29, 2024 20:49
@Anavelyz Anavelyz force-pushed the 143-python-coc-support branch from 4131401 to e4b798d Compare February 29, 2024 22:22
@Anavelyz
Copy link
Collaborator Author

Anavelyz commented Feb 29, 2024

@Anavelyz could you rebase your branch on top of the main upstream branch please?

Done!

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Anavelyz

@xmnlab xmnlab merged commit 6334b2b into osl-incubator:main Mar 1, 2024
11 checks passed
@Anavelyz Anavelyz deleted the 143-python-coc-support branch March 1, 2024 18:25
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xmnlab xmnlab mentioned this pull request Mar 29, 2024
1 task
YurelyCamacho pushed a commit to YurelyCamacho/cookiecutter-python that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants