Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(project information): Adding the maintainer section to readme #145

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented Jul 12, 2023

Pull Request description

The section for maintainers of the project has been added. This is a list of the names of the current SciCookie maintainers, in alphabetical order, with their respective GitHub usernames.

Co-authored-by: @YurelyCamacho

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved.

@Anavelyz
Copy link
Collaborator Author

@xmnlab @YurelyCamacho Can you review this? Please

@xmnlab
Copy link
Member

xmnlab commented Jul 13, 2023

@Anavelyz , lgtm. just let's wait a bit here before we can merge it.
I am checking why this is really slow ... not sure if it is a problem with mamba or miniconda-setup (or maybe conda).

@xmnlab
Copy link
Member

xmnlab commented Jul 13, 2023

I saw the same issue for other projects as well

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anavelyz could you rebase your branch please?
sorry, as I asked you before to change main.yaml .. and I also I pushed a change there too
it will raise a conflict there.

let's keep it as 1.*

xmnlab added 3 commits July 13, 2023 12:45
* Add channel-priority: true to the workflows inside the template folder
* Pin mamba-version to 1.*
* Add channel-priority: true to the workflows inside the template folder
* Pin mamba-version to 1.*
@xmnlab
Copy link
Member

xmnlab commented Jul 13, 2023

thanks for working on that @Anavelyz ! lgtm

@xmnlab xmnlab merged commit 321417b into osl-incubator:main Jul 13, 2023
@Anavelyz Anavelyz deleted the maintainers branch July 13, 2023 17:53
@github-actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants