-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template): adding meson-python as a build-system option #139
Conversation
@xmnlab I have created this PR by adding the meson-python option as build system to see what happens with the tests. I still need to add the documentation, I will do it when I'm sure that everything else is working fine. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YurelyCamacho thanks for working on that.
it is looking great.
just a small comment inline here
I hope to finish my PR fixing some general issues with the smoke test
and I will ping you to ask you to rebase your code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YurelyCamacho looks good to me.
could you rebase your branch on top of the upstream/main please?
just merged the PR fixing some issues with the smoke test.
also, as you mentioned on discord, could you ensure that these tests are being executed on CI please?
thanks!
@YurelyCamacho it seems your PR included changes from my last PR, and now it is blocking with some git conflicts. |
@YurelyCamacho in general looks good. could you add the build-system smoke to be executed on CI please? |
@xmnlab Didn't run build-system test, error with flit. What can I do now? |
tests/smoke/base.sh
Outdated
@@ -44,6 +45,8 @@ if command -v poetry &> /dev/null; then | |||
poetry install | |||
elif command -v flit &> /dev/null; then | |||
flit install | |||
elif command -v mesonpy &> /dev/null; then | |||
meson install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the command would be pip install .
instead
tests/smoke/base.sh
Outdated
@@ -44,6 +45,8 @@ if command -v poetry &> /dev/null; then | |||
poetry install | |||
elif command -v flit &> /dev/null; then | |||
flit install | |||
elif command -v mesonpy &> /dev/null; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be meson instead of meonspy
@xmnlab It is a problem with the installation of the package. It could be something with the |
I was looking at this to see if it solved the error. https://mkdocstrings.github.io/python/usage/ |
@YurelyCamacho good job! it seems that worked! congrats :) |
🎉 This PR is included in version 0.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Solve #55
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Reviewer's Checklist
main
branch