This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 260
/
shim_fs_lock.c
610 lines (525 loc) · 18.4 KB
/
shim_fs_lock.c
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
/* SPDX-License-Identifier: LGPL-3.0-or-later */
/* Copyright (C) 2021 Intel Corporation
* Paweł Marczewski <[email protected]>
*/
#include <linux/fcntl.h>
#include "shim_fs.h"
#include "shim_fs_lock.h"
#include "shim_ipc.h"
#include "shim_lock.h"
/* Describes a pending request for a POSIX lock, either local on remote. After processing the request,
* the object is removed, and a possible waiter is notified (see below). */
DEFINE_LISTP(posix_lock_request);
DEFINE_LIST(posix_lock_request);
struct posix_lock_request {
struct posix_lock pl;
/* For local requests, `event` should be set to an event handle. After processing the request,
* the event will be triggered, and `*result` will be set to the result. */
PAL_HANDLE event;
int* result;
/* For remote requests, `vmid` and `seq` should be set to parameters of IPC message. After
* processing the request, IPC response will be sent. */
IDTYPE vmid;
unsigned int seq;
LIST_TYPE(posix_lock_request) list;
};
/* Describes file lock details for a given dentry. Currently holds only POSIX locks. */
DEFINE_LISTP(fs_lock);
DEFINE_LIST(fs_lock);
struct fs_lock {
struct shim_dentry* dent;
/* POSIX locks, sorted by PID and then by start position. The ranges do not overlap within a
* given PID. */
LISTP_TYPE(posix_lock) posix_locks;
/* Pending requests. */
LISTP_TYPE(posix_lock_request) posix_lock_requests;
LIST_TYPE(fs_lock) list;
};
/* Global list of `fs_lock` objects. Used for cleanup. */
static LISTP_TYPE(fs_lock) g_fs_lock_list = LISTP_INIT;
/* Global lock for all operations on filesystem locks, including access to dentry `fs_lock` and
* `maybe_has_locks` fields. */
static struct shim_lock g_fs_lock_lock;
int init_fs_lock(void) {
if (g_process_ipc_ids.leader_vmid)
return 0;
return create_lock(&g_fs_lock_lock);
}
static int find_fs_lock(struct shim_dentry* dent, bool create, struct fs_lock** out_fs_lock) {
assert(locked(&g_fs_lock_lock));
if (!dent->fs_lock && create) {
struct fs_lock* fs_lock = malloc(sizeof(*fs_lock));
if (!fs_lock)
return -ENOMEM;
fs_lock->dent = dent;
get_dentry(dent);
INIT_LISTP(&fs_lock->posix_locks);
INIT_LISTP(&fs_lock->posix_lock_requests);
dent->fs_lock = fs_lock;
LISTP_ADD(fs_lock, &g_fs_lock_list, list);
}
*out_fs_lock = dent->fs_lock;
return 0;
}
static int posix_lock_dump_write_all(const char* str, size_t size, void* arg) {
__UNUSED(arg);
log_always("posix_lock: %.*s", (int)size, str);
return 0;
}
/* Log current locks for a file, for debugging purposes. */
static void posix_lock_dump(struct fs_lock* fs_lock) {
assert(locked(&g_fs_lock_lock));
struct print_buf buf = INIT_PRINT_BUF(&posix_lock_dump_write_all);
IDTYPE pid = 0;
struct posix_lock* pl;
LISTP_FOR_EACH_ENTRY(pl, &fs_lock->posix_locks, list) {
if (pl->pid != pid) {
if (pid != 0)
buf_flush(&buf);
pid = pl->pid;
buf_printf(&buf, "%d:", pid);
}
char c;
switch (pl->type) {
case F_RDLCK: c = 'r'; break;
case F_WRLCK: c = 'w'; break;
default: c = '?'; break;
}
if (pl->end == FS_LOCK_EOF) {
buf_printf(&buf, " %c[%lu..end]", c, pl->start);
} else {
buf_printf(&buf, " %c[%lu..%lu]", c, pl->start, pl->end);
}
}
if (LISTP_EMPTY(&fs_lock->posix_locks)) {
buf_printf(&buf, "no locks");
}
buf_flush(&buf);
}
/* Removes `fs_lock` if it's not necessary (i.e. no locks are held or requested for a file). */
static void fs_lock_gc(struct fs_lock* fs_lock) {
assert(locked(&g_fs_lock_lock));
if (g_log_level >= LOG_LEVEL_DEBUG)
posix_lock_dump(fs_lock);
if (LISTP_EMPTY(&fs_lock->posix_locks) && LISTP_EMPTY(&fs_lock->posix_lock_requests)) {
struct shim_dentry* dent = fs_lock->dent;
dent->fs_lock = NULL;
put_dentry(dent);
LISTP_DEL(fs_lock, &g_fs_lock_list, list);
free(fs_lock);
}
}
/*
* Find first lock that conflicts with `pl`. Two locks conflict if they have different PIDs, their
* ranges overlap, and at least one of them is a write lock.
*/
static struct posix_lock* posix_lock_find(struct fs_lock *fs_lock, struct posix_lock* pl) {
assert(locked(&g_fs_lock_lock));
assert(pl->type != F_UNLCK);
struct posix_lock* cur;
LISTP_FOR_EACH_ENTRY(cur, &fs_lock->posix_locks, list) {
if (cur->pid != pl->pid && pl->start <= cur->end && cur->start <= pl->end
&& (cur->type == F_WRLCK || pl->type == F_WRLCK))
return cur;
}
return NULL;
}
/*
* Add a new lock request. Before releasing `g_fs_lock_lock`, the caller has to add notification
* info to the request (see `struct posix_lock_request` above).
*/
static int posix_lock_add_request(struct fs_lock *fs_lock, struct posix_lock* pl,
struct posix_lock_request** out_req) {
assert(locked(&g_fs_lock_lock));
assert(pl->type != F_UNLCK);
struct posix_lock_request *req = malloc(sizeof(*req));
if (!req)
return -ENOMEM;
req->pl = *pl;
req->event = NULL;
LISTP_ADD(req, &fs_lock->posix_lock_requests, list);
*out_req = req;
return 0;
}
/*
* Main part of `posix_lock_set`. Adds/removes a lock (depending on `pl->type`), assumes we already
* verified there are no conflicts. Replaces existing locks for a given PID, and merges adjacent
* locks if possible.
*
* See also Linux sources (`fs/locks.c`) for a similar implementation.
*/
static int _posix_lock_set(struct fs_lock *fs_lock, struct posix_lock* pl) {
assert(locked(&g_fs_lock_lock));
/* Preallocate new locks first, so that we don't fail after modifying something. */
/* Lock to be added. Not necessary for F_UNLCK, because we're only removing existing locks. */
struct posix_lock* new = NULL;
if (pl->type != F_UNLCK) {
new = malloc(sizeof(*new));
if (!new)
return -ENOMEM;
}
/* Extra lock that we might need when splitting existing one. */
struct posix_lock* extra = malloc(sizeof(*extra));
if (!extra) {
free(new);
return -ENOMEM;
}
/* Target range: we will be changing it when merging existing locks. */
uint64_t start = pl->start, end = pl->end;
/* `prev` will be set to the last lock before target range, so that we add the new lock just
* after `prev`. */
struct posix_lock* prev = NULL;
struct posix_lock* cur;
struct posix_lock* tmp;
LISTP_FOR_EACH_ENTRY_SAFE(cur, tmp, &fs_lock->posix_locks, list) {
if (cur->pid < pl->pid) {
prev = cur;
continue;
}
if (pl->pid < cur->pid) {
break;
}
if (pl->type == cur->type) {
/* Same lock type: we can possibly merge the locks. */
if (start > 0 && cur->end < start - 1) {
/* `cur` ends before target range begins, and is not even adjacent */
prev = cur;
} else if (end < FS_LOCK_EOF && end + 1 < cur->start) {
/* `cur` begins after target range ends, and is not even adjacent - we're
* done */
break;
} else {
/* `cur` is either adjacent to target range, or overlaps with it. Delete it, and
* expand the target range. */
start = MIN(start, cur->start);
end = MAX(end, cur->end);
LISTP_DEL(cur, &fs_lock->posix_locks, list);
free(cur);
}
} else {
/* Different lock types: if they overlap, we delete the target range. */
if (cur->end < start) {
/* `cur` ends before target range begins */
prev = cur;
} else if (end < cur->start) {
/* `cur` begins after target range ends - we're done */
break;
} else if (cur->start < start && cur->end <= end) {
/*
* `cur` overlaps with beginning of target range. Shorten `cur`.
*
* cur: =======
* tgt: -------
*
* cur: ==
*/
assert(start > 0);
cur->end = start - 1;
prev = cur;
} else if (cur->start < start && cur->end > end) {
/*
* The target range is inside `cur`. Split `cur` and finish.
*
* cur: ========
* tgt: ----
*
* cur: ==
* extra: ==
*/
/* We'll need `extra` only once, because we exit the loop afterwards. */
assert(extra);
assert(start > 0);
extra->type = cur->type;
extra->start = end + 1;
extra->end = cur->end;
extra->pid = cur->pid;
cur->end = start - 1;
LISTP_ADD_AFTER(extra, cur, &fs_lock->posix_locks, list);
extra = NULL;
/* We're done: the new lock, if any, will be added after `cur`. */
prev = cur;
break;
} else if (start <= cur->start && cur->end <= end) {
/*
* `cur` is completely covered by target range. Delete `cur`.
*
* cur: ====
* tgt: --------
*/
LISTP_DEL(cur, &fs_lock->posix_locks, list);
free(cur);
} else {
/*
* `cur` overlaps with end of target range. Shorten `cur` and finish.
*
* cur: ====
* tgt: -----
*
* cur: ==
*/
assert(start <= cur->start && end < cur->end);
assert (end < FS_LOCK_EOF);
cur->start = end + 1;
break;
}
}
}
if (new) {
assert(pl->type != F_UNLCK);
new->type = pl->type;
new->start = start;
new->end = end;
new->pid = pl->pid;
#ifdef DEBUG
/* Assert that list order is preserved */
struct posix_lock* next = prev ? LISTP_NEXT_ENTRY(prev, &fs_lock->posix_locks, list)
: LISTP_FIRST_ENTRY(&fs_lock->posix_locks, struct posix_lock, list);
if (prev)
assert(prev->pid < pl->pid || (prev->pid == pl->pid && prev->end < start));
if (next)
assert(pl->pid < next->pid || (pl->pid == next->pid && end < next->start));
#endif
if (prev) {
LISTP_ADD_AFTER(new, prev, &fs_lock->posix_locks, list);
} else {
LISTP_ADD(new, &fs_lock->posix_locks, list);
}
}
if (extra)
free(extra);
return 0;
}
/*
* Process pending requests after modifying the list of locks.
*
* TODO: This is pretty inefficient, but perhaps good enough for now...
*/
static void posix_lock_process_requests(struct fs_lock *fs_lock) {
assert(locked(&g_fs_lock_lock));
bool changed;
do {
changed = false;
struct posix_lock_request* req;
struct posix_lock_request* tmp;
LISTP_FOR_EACH_ENTRY_SAFE(req, tmp, &fs_lock->posix_lock_requests, list) {
struct posix_lock* conflict = posix_lock_find(fs_lock, &req->pl);
if (!conflict) {
int result = _posix_lock_set(fs_lock, &req->pl);
LISTP_DEL(req, &fs_lock->posix_lock_requests, list);
if (req->event) {
assert(req->result);
*req->result = result;
DkEventSet(req->event);
}
if (req->vmid) {
int ret = ipc_posix_lock_set_send_response(req->vmid, req->seq, result);
if (ret < 0) {
log_warning("posix lock: error sending result over IPC: %d", ret);
}
}
free(req);
changed = true;
}
}
} while (changed);
}
static int posix_lock_set_or_add_request(struct shim_dentry* dent, struct posix_lock* pl, bool wait,
struct posix_lock_request** out_req) {
assert(locked(&g_fs_lock_lock));
struct fs_lock* fs_lock = NULL;
int ret = find_fs_lock(dent, /*create=*/pl->type != F_UNLCK, &fs_lock);
if (ret < 0)
goto out;
if (!fs_lock) {
assert(pl->type == F_UNLCK);
/* Nothing to unlock. */
return 0;
}
struct posix_lock* conflict = NULL;
if (pl->type != F_UNLCK)
conflict = posix_lock_find(fs_lock, pl);
if (conflict) {
if (!wait)
return -EAGAIN;
struct posix_lock_request* req;
ret = posix_lock_add_request(fs_lock, pl, &req);
if (ret < 0)
goto out;
*out_req = req;
} else {
*out_req = NULL;
ret = _posix_lock_set(fs_lock, pl);
if (ret < 0)
goto out;
posix_lock_process_requests(fs_lock);
*out_req = NULL;
}
ret = 0;
out:
if (fs_lock)
fs_lock_gc(fs_lock);
return ret;
}
int posix_lock_set(struct shim_dentry* dent, struct posix_lock* pl, bool wait) {
int ret;
if(g_process_ipc_ids.leader_vmid) {
/* In the IPC version, we use `dent->maybe_has_locks` to short-circuit unlocking files that
* we never locked. This is to prevent unnecessary IPC calls on on handle. */
lock(&g_fs_lock_lock);
if (pl->type == F_RDLCK || pl->type == F_WRLCK) {
dent->maybe_has_locks = true;
} else if (!dent->maybe_has_locks) {
/* We know we're not holding any locks for the file */
unlock(&g_fs_lock_lock);
return 0;
}
unlock(&g_fs_lock_lock);
char* path;
ret = dentry_abs_path(dent, &path, /*size=*/NULL);
if (ret < 0)
return ret;
ret = ipc_posix_lock_set(path, pl, wait);
free(path);
return ret;
}
lock(&g_fs_lock_lock);
PAL_HANDLE event = NULL;
struct posix_lock_request* req = NULL;
ret = posix_lock_set_or_add_request(dent, pl, wait, &req);
if (ret < 0)
goto out;
if (req) {
assert(wait);
int result;
ret = DkEventCreate(&event, /*init_signaled=*/false, /*auto_clear=*/false);
if (ret < 0)
goto out;
req->event = event;
req->result = &result;
unlock(&g_fs_lock_lock);
ret = object_wait_with_retry(event);
lock(&g_fs_lock_lock);
if (ret < 0)
goto out;
ret = result;
} else {
ret = 0;
}
out:
unlock(&g_fs_lock_lock);
if (event)
DkObjectClose(event);
return ret;
}
int posix_lock_set_from_ipc(const char* path, struct posix_lock* pl, bool wait, IDTYPE vmid,
unsigned long seq, bool* postponed) {
assert(!g_process_ipc_ids.leader_vmid);
struct shim_dentry* dent = NULL;
struct posix_lock_request* req = NULL;
int ret = path_lookupat(g_dentry_root, path, LOOKUP_NO_FOLLOW, &dent);
if (ret < 0) {
log_warning("posix_lock_set_from_ipc: error on dentry lookup for %s: %d", path, ret);
goto out;
}
lock(&g_fs_lock_lock);
ret = posix_lock_set_or_add_request(dent, pl, wait, &req);
unlock(&g_fs_lock_lock);
if (ret < 0)
goto out;
if (req) {
assert(wait);
req->vmid = vmid;
req->seq = seq;
*postponed = true;
} else {
*postponed = false;
}
ret = 0;
out:
if (dent)
put_dentry(dent);
return ret;
}
int posix_lock_get(struct shim_dentry* dent, struct posix_lock* pl, struct posix_lock* out_pl) {
assert(pl->type != F_UNLCK);
int ret;
if (g_process_ipc_ids.leader_vmid) {
char* path;
ret = dentry_abs_path(dent, &path, /*size=*/NULL);
if (ret < 0)
return ret;
ret = ipc_posix_lock_get(path, pl, out_pl);
free(path);
return ret;
}
lock(&g_fs_lock_lock);
struct fs_lock* fs_lock = NULL;
ret = find_fs_lock(dent, /*create=*/false, &fs_lock);
if (ret < 0)
goto out;
struct posix_lock* conflict = NULL;
if (fs_lock)
conflict = posix_lock_find(fs_lock, pl);
if (conflict) {
out_pl->type = conflict->type;
out_pl->start = conflict->start;
out_pl->end = conflict->end;
out_pl->pid = conflict->pid;
} else {
out_pl->type = F_UNLCK;
}
ret = 0;
out:
if (fs_lock)
fs_lock_gc(fs_lock);
unlock(&g_fs_lock_lock);
return ret;
}
int posix_lock_get_from_ipc(const char* path, struct posix_lock* pl, struct posix_lock* out_pl) {
assert(!g_process_ipc_ids.leader_vmid);
struct shim_dentry* dent = NULL;
int ret = path_lookupat(g_dentry_root, path, LOOKUP_NO_FOLLOW, &dent);
if (ret < 0) {
log_warning("posix_lock_get_from_ipc: error on dentry lookup for %s: %d", path, ret);
return ret;
}
ret = posix_lock_get(dent, pl, out_pl);
put_dentry(dent);
return ret;
}
int posix_lock_clear_pid(IDTYPE pid) {
if (g_process_ipc_ids.leader_vmid) {
return ipc_posix_lock_clear_pid(pid);
}
log_debug("clearing POSIX locks for pid %d", pid);
lock(&g_fs_lock_lock);
struct fs_lock* fs_lock;
struct fs_lock* tmp;
LISTP_FOR_EACH_ENTRY_SAFE(fs_lock, tmp, &g_fs_lock_list, list) {
struct posix_lock* pl;
struct posix_lock* pl_tmp;
bool changed = false;
LISTP_FOR_EACH_ENTRY_SAFE(pl, pl_tmp, &fs_lock->posix_locks, list) {
if (pl->pid == pid) {
LISTP_DEL(pl, &fs_lock->posix_locks, list);
free(pl);
changed = true;
}
}
struct posix_lock_request* req;
struct posix_lock_request* req_tmp;
LISTP_FOR_EACH_ENTRY_SAFE(req, req_tmp, &fs_lock->posix_lock_requests, list) {
if (req->pl.pid == pid) {
assert(!req->event);
LISTP_DEL(req, &fs_lock->posix_lock_requests, list);
free(req);
}
}
if (changed) {
posix_lock_process_requests(fs_lock);
fs_lock_gc(fs_lock);
}
}
unlock(&g_fs_lock_lock);
return 0;
}