Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unbuildable manifests with osbuild --inspect #61

Open
achilleas-k opened this issue Oct 11, 2022 · 1 comment
Open

Check unbuildable manifests with osbuild --inspect #61

achilleas-k opened this issue Oct 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@achilleas-k
Copy link
Member

Some manifests can't be built because they need to download sources that aren't available. In particular, ostree-based image types that rely on pulling an existing commit, like the edge/iot-installer and edge/iot-raw-image types, need to pull an ostree commit to embed it in an installer or raw image. For this, we just generate manifests with fake values for the ostree source so that we have a test manifest for change detection alone.

While these can't be built, they can be verified to be correct, using osbuild --inspect and checked for errors.

NB: With the current manifests, these will fail because of the parent commit ID being malformed in our test manifests, but that's a small issue to fix.

@achilleas-k achilleas-k added the enhancement New feature or request label Oct 11, 2022
@lavocatt
Copy link
Contributor

lavocatt commented Oct 12, 2022

Thanks for bringing this issue. I believe these are caught by the osbulid-image-tests command as manifest validation failed right ?

So if I understand it correctly, we could have a special treatment for them ? by just verify them with osbuild --inspect

Let me propose an alternative:
We could keep an ostree commit on S3, always reference it in the DB, and add a prerequisite for these manifests to have the file accessible on disk.

What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants