Skip to content

gen-manifests: print stacktrace of first error #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achilleas-k merged 1 commit into from
Oct 2, 2025
Merged

gen-manifests: print stacktrace of first error #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions cmd/gen-manifests/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ package main
import (
"crypto/sha256"
"encoding/json"
"errors"
"flag"
"fmt"
"os"
"path/filepath"
"runtime/debug"
"strings"
"time"

Expand Down Expand Up @@ -39,6 +41,16 @@ import (
testrepos "github.com/osbuild/images/test/data/repositories"
)

// panicError is a custom error type to wrap a panic and its stack trace.
type panicError struct {
panic any
stack []byte
}

func (e *panicError) Error() string {
return fmt.Sprintf("panic: %v", e.panic)
}

type buildRequest struct {
Distro string `json:"distro,omitempty"`
Arch string `json:"arch,omitempty"`
Expand Down Expand Up @@ -260,7 +272,10 @@ func makeManifestJob(
}()
defer func() {
if r := recover(); r != nil {
err = fmt.Errorf("[%s] failed with panic: %s", filename, r)
err = fmt.Errorf("[%s] failed: %w", filename, &panicError{
panic: r,
stack: debug.Stack(),
})
}
}()
msgq <- fmt.Sprintf("Starting job %s", filename)
Expand Down Expand Up @@ -660,10 +675,18 @@ func main() {
fmt.Println("done")
errs := wq.wait()
exit := 0
if len(errs) > 0 {
fmt.Fprintf(os.Stderr, "Encountered %d errors:\n", len(errs))
if nErrs := len(errs); nErrs > 0 {
fmt.Fprintf(os.Stderr, "Encountered %d errors:\n", nErrs)
var err1 *panicError
for idx, err := range errs {
fmt.Fprintf(os.Stderr, "%3d: %s\n", idx, err.Error())
if err1 == nil {
errors.As(err, &err1)
}
}

if err1 != nil {
fmt.Fprintf(os.Stderr, "\nStack trace of the first error:\n%s\n", err1.stack)
}
exit = 1
}
Expand Down
Loading