From 3d27703558c67b7746ea1cce89418aa4bcabfebf Mon Sep 17 00:00:00 2001 From: Juan Hernandez Date: Tue, 23 Jun 2026 16:16:33 +0200 Subject: [PATCH] NO-ISSUE: Remove gRPC probe hook The fulfillment-service upstream Helm charts now include increased probe timeouts (`timeoutSeconds` and `failureThreshold`) directly, as per https://github.com/osac-project/fulfillment-service/pull/743. This makes the post-install hook that patched the gRPC server deployment unnecessary, so remove it. Assisted-by: Cursor Signed-off-by: Juan Hernandez --- .../templates/hooks/patch-grpc-probes.yaml | 53 ------------------- 1 file changed, 53 deletions(-) delete mode 100644 charts/osac/templates/hooks/patch-grpc-probes.yaml diff --git a/charts/osac/templates/hooks/patch-grpc-probes.yaml b/charts/osac/templates/hooks/patch-grpc-probes.yaml deleted file mode 100644 index f094d3fc..00000000 --- a/charts/osac/templates/hooks/patch-grpc-probes.yaml +++ /dev/null @@ -1,53 +0,0 @@ -{{/* -TODO: Remove once the fulfillment-service subchart uses longer probe timeouts. -The exec-based readiness probe spawns a full process; under CPU/IO pressure from -AAP automation jobs on single-node clusters, process startup alone can exceed the -default 1s timeout, causing the headless Service to drop the pod IP and Envoy to -return "no healthy upstream" for ~5s. -*/}} -apiVersion: batch/v1 -kind: Job -metadata: - name: osac-patch-grpc-probes - namespace: {{ .Release.Namespace }} - labels: - {{- include "osac.labels" . | nindent 4 }} - annotations: - "helm.sh/hook": post-install,post-upgrade - "helm.sh/hook-weight": "-5" - "helm.sh/hook-delete-policy": before-hook-creation -spec: - backoffLimit: 3 - activeDeadlineSeconds: 120 - template: - metadata: - labels: - {{- include "osac.labels" . | nindent 8 }} - spec: - restartPolicy: Never - serviceAccountName: osac-sa - containers: - - name: patch - image: quay.io/openshift/origin-cli:4.20.0 - securityContext: - allowPrivilegeEscalation: false - readOnlyRootFilesystem: true - capabilities: - drop: ["ALL"] - resources: - requests: - cpu: 50m - memory: 64Mi - limits: - cpu: 200m - memory: 128Mi - command: - - oc - - patch - - deploy/fulfillment-grpc-server - - -n - - {{ .Release.Namespace }} - - --type=strategic - - -p - - | - {"spec":{"template":{"spec":{"containers":[{"name":"grpc-server","livenessProbe":{"timeoutSeconds":5,"failureThreshold":5},"readinessProbe":{"timeoutSeconds":5,"failureThreshold":5}}]}}}}