Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Trino 431 or later #365

Open
MichaelTiemannOSC opened this issue Dec 9, 2023 · 4 comments
Open

Need Trino 431 or later #365

MichaelTiemannOSC opened this issue Dec 9, 2023 · 4 comments
Assignees

Comments

@MichaelTiemannOSC
Copy link
Contributor

MichaelTiemannOSC commented Dec 9, 2023

It turns out that Java regexps don't support all the features available in Python regexps (no conditional statement execution), but there is a work-around to write little functions that do the conditional execution manually...if only such little functions can be written. As of 431, I believe they can be: https://trinodb.slack.com/archives/C0305TQ05KL/p1701760286720039?thread_ts=1701702080.522839&cid=C0305TQ05KL

Trino 434 is the latest version of Trino, and presumably that or 435 (expected next week) would be good versions to evaluate as an update to our current 424 version.

@MichaelTiemannOSC MichaelTiemannOSC converted this from a draft issue Dec 9, 2023
@MichaelTiemannOSC MichaelTiemannOSC changed the title Need Trino 434 or later Need Trino 431 or later Dec 9, 2023
@eharrison24 eharrison24 moved this from Todo to In Progress in Data Commons - Q4 2023 Dec 11, 2023
@MichaelTiemannOSC
Copy link
Contributor Author

A caution that we want to see this (near simultaneous inserts into iceberg don't fully commit) resolved before deploying a new version: https://trinodb.slack.com/archives/CJ6UC075E/p1702376393926019. If I were Trino, I'd make this a blocker for 435 and release that when solved. The problem is somewhere between 428 (we are at 424) and 434. No idea whether it's coincidentally 431 (features we need), before that, or after that.

@MichaelTiemannOSC
Copy link
Contributor Author

My read of the latest on slack is that the Trino folks think that whatever's gone wrong in Iceberg is an Iceberg problem (33 messages back-and-forth and counting). They released 435 in light of this, so I think we should put 435 into the queue as the version to move forward with. They also re-affirmed an aspiration to return to weekly release cadences, so if this goes wrong, we should expect a fix just before Christmas.

@MichaelTiemannOSC
Copy link
Contributor Author

And now iceberg has a PR addressing the problem: apache/iceberg#9230

@MichaelTiemannOSC
Copy link
Contributor Author

Another FYI from Trino Slack: https://trinodb.slack.com/archives/CGB0QHWSW/p1702977030476319. Note that Trino team have been testing Java 21 for while, but something is up in the Graviton world. I don't know whether we run Graviton instances or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants