-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support different jwt scope claim strategies #3531
feat: support different jwt scope claim strategies #3531
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3531 +/- ##
==========================================
- Coverage 76.64% 76.62% -0.02%
==========================================
Files 129 129
Lines 9630 9640 +10
==========================================
+ Hits 7381 7387 +6
- Misses 1748 1751 +3
- Partials 501 502 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 🎉 Your contribution makes Ory better :)
d587c93
to
3c986de
Compare
Hello @brett-patterson Let me know if I can support you in adding something to the documentation. I have never used the feature so I would need some rough pointers/drafts. Thanks! |
Hi there! I have a question for the Ory guys: is this feature already a part of any release? If yes, which one? If no, when should we expect it? |
Adds a
strategies.jwt.scope_claim
optional configuration property that controls how the scope claim is represented in JWT access tokens. It can be set to one oflist
,string
, orboth
.list
(the default behavior) matches the current behavior of using ascp
claim that is an array of strings.string
uses ascope
claim as defined in this RFC, a single space-delimited string.both
will include both thescp
andscope
claim in the token.Related issue(s)
#3524
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
These different scope claim strategies were already available in
fosite
, this PR is just exposing them through a Hydra configuration property. Open to suggestions on configuration property naming! Will update docs but wanted to get this PR settled first to know what to add to the docs.