-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different formats of scopes #1263
Comments
Sorry for the late reply. Generally that's a possibility - one thing to keep in mind with |
No worries. |
We also have (legacy) scope identifiers with |
We're open to accepting a PR. This should be done both in fosite (as a scope strategy) and hydra (as a configuration value). If you are looking to do a PR please discuss the changes beforehand as it will save some time :) |
Looks like a nice task to start with Go :) |
The fix would just be to add the delimiter as a parameter to the wildcard strategy? |
yep exactly! I think we can add it to wildcard and hierarchical! |
@tacurran is this a feature that would make sense implementing? |
Sorry, I don't have time at the moment. |
Closing due to lack of public interest. |
Hey, @aeneasr would you mind reopening this? I could help look into it. Would this involve changes in Fosite? - https://github.com/ory/fosite/blob/master/scope_strategy.go#L69 |
@sidharthramesh agree, that would be great. we have permissions with |
Is your feature request related to a problem? Please describe.
Hydra splits checking of scopes on
.
. It makes the assumption that scopes are dot separated. We have a use case where the scope needs to contain a:
. A example of the scope ispayments:xyz
. I would like to create a client that has all scopes underpayments
. If it were dot separated I can create a client with scopespayments.*
. I cannot do that with the:
. I cannot create a client which has an allowed scopepayments:*
.Describe the solution you'd like
I would like the ability to create a client with scopes separated by
:
. It would be good to be able to set a regular expression based scope strategy.The text was updated successfully, but these errors were encountered: