Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNBD and more darty api #86

Open
KalilDev opened this issue Aug 8, 2022 · 2 comments
Open

NNBD and more darty api #86

KalilDev opened this issue Aug 8, 2022 · 2 comments

Comments

@KalilDev
Copy link

KalilDev commented Aug 8, 2022

In dart, the convention is camelCase, final fields, and now, nnbd. The package needs an great migration. I did it at my github, but it is an humongous breaking change and contains 3 packages that i made and didnt publish to pub.dev. I tried to only migrate to nnbd but because the fields are set after object initialization, it proved to be rather chalenging. So as it was becoming an big breaking change with big consequences i ended up doing it my way.

@KalilDev
Copy link
Author

KalilDev commented Aug 8, 2022

So, how do we go from here? Do you have any intention on continuing to develop this package? Do you want me to retry the migration (although, because of the mentioned issues, most, if not all, the fields will be nullable)? Probably just keeping this package as an legacy one and not migrating is totally fine also, i just did it for an personal project, in which i also used a lot of private dart-epub apis, not the intended usecase of the package, so its kinda obvious that it bit me

@KalilDev
Copy link
Author

KalilDev commented Aug 8, 2022

Yeah, i just checked epubx, everything is nullable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant