-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Merge implementation of epub_write into epub #30
Comments
Hey @ShadowJonathan I actually did a fair amount of the merge between the two last week. If you check the lib/src/epub_writer.dart file and lib/src/writers directory, I tried to merge as much of the functionality as I could. I added a few integration tests for them as well. Is this what you were looking for? Thanks! |
I like it! I havent done a test on it yet (read a epub, then write it again, and compare differences), but so far it seems like a better version of what i managed to write! |
I'm glad you like it! I didn't do much other than refactor and split a lot of what was originally in epub_write and added a few extra methods for processing more metadata, so thank you! I wrote and added a few tests to the package that do round trip to ensure the content that is written can be re-read back. If you want to take a look I'd appreciate it! |
Will do! Also I suggest making a "EpubFactory" class, since both |
There's a dart package out there, epub_write, which is supposed to add writing functionality, making it possible to (painstakingly) create epub files directly from epub book "references"
My suggestion, and question, is to merge that functionality into this package?
The text was updated successfully, but these errors were encountered: