Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try/catch on invoke does not work #10

Open
RubenMateus opened this issue Nov 25, 2024 · 4 comments
Open

Try/catch on invoke does not work #10

RubenMateus opened this issue Nov 25, 2024 · 4 comments

Comments

@RubenMateus
Copy link

Hello, i have been using the Orq.Ai SDK for a week now and it seems that try/catch the invoke method is not working properly.

Even if I try/catch the invoke method it's not caught by it.

I think I have found the issue for that.
In the function called: handleRequestError is marked as async but it is not awaited when you call it. Even so, I don't think this function should be marked as async.

Am I missing something here?

@RubenMateus
Copy link
Author

@thedevtoni can you please take a look?

AI generated a PR but I cannot open it because I am not a collaborator.
https://github.com/orq-ai/orq-node/compare/orq-ai:main...lkilu6456546:feat/a8096842-4a94-497e-92aa-b612fd8a6112?expand=1

@thedevtoni
Copy link
Contributor

Hey @RubenMateus, this week we are realising the new SDK's which should improve this type of things, I will keep you posted once it's publish.

I'm gonna publish an article of the braking changes because there may some.

@RubenMateus
Copy link
Author

Thats great to ear. When can we expect this changes to come?

@thedevtoni
Copy link
Contributor

@RubenMateus next week, we currently have the version of the SDK in canary release, should be live in the our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@RubenMateus @thedevtoni and others