Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin causing errors in project reports #187

Closed
bradleylarrick opened this issue Aug 18, 2022 · 6 comments
Closed

Plugin causing errors in project reports #187

bradleylarrick opened this issue Aug 18, 2022 · 6 comments
Assignees

Comments

@bradleylarrick
Copy link

Running the launch4j-maven-plugin is corrupting the results of the maven-project-info-reports-plugin. The Plugin Management and Plugins reports have all the GroupId, ArtifactId and Version values replaced with the GroupId, ArtifactId and Version of the current project.

A sample project reproducing the problem can be found at https://github.com/bradleylarrick/launch4j-plugin-error.git.

@bradleylarrick
Copy link
Author

I did some additional testing on this and determined that the problem is caused by the following line in the retrieveBinaryBits() method in Launch4jMojo:

    configuration.setProject(session.getCurrentProject());

Commenting out this line in my environment solved the problem with no apparent side effects.

@lukaszlenart
Copy link
Collaborator

Thanks for taking a look into that, I wonder how to solve this - maybe a dedicated configuration option to disable such behaviour would be a good idea?

@lukaszlenart lukaszlenart self-assigned this Sep 4, 2022
@bradleylarrick
Copy link
Author

As I mentioned above, commenting out the line that sets the project in the configuration object solved the problem.

@bradleylarrick
Copy link
Author

BTW: Once I figured out how to properly configure the JRE path, version 2.2.0 works without this problem.

@lukaszlenart
Copy link
Collaborator

Not sure if I get it, so there is no problem, right? And we can close this issue?

@bradleylarrick
Copy link
Author

That's correct. The problem appears to be solved in 2.2. This ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants