Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI data plane #4496

Closed
eisenhauer opened this issue Mar 28, 2025 · 1 comment · Fixed by #4498
Closed

MPI data plane #4496

eisenhauer opened this issue Mar 28, 2025 · 1 comment · Fixed by #4498
Assignees
Labels
api: C C API related area: build Build issues sustainability Related to sustainability effort triage: low This issue is a nice-to-have if we can get to it but isn't holding anybody up.

Comments

@eisenhauer
Copy link
Member

The way we're handling the MPI data plane currently is restrictive. The dataplane is not built if MPICH is not detected, and if you manage to force it to build, there is an #if defined(MPICH) in mpi_dp.c that automatically disables it.

Instead, we should always build the MPI data plane if MPI_open_port() is present in the in-use MPI library. If we're not confident that the MPI in use supports connecting disparate jobs, we should modify the value returned in MpiGetPriority() to something that would fall behind other DPs. This would allow users to try their MPI to see if it works without requiring source code changes.

@vicentebolea
Copy link
Collaborator

Fair point, the restrictiveness of the MPI dataplane was due to the avalanche of users issues that we got that were boiled down to just using MPI deployments that did not really support Client/Server comm, in addition to that we only targeted a few HPC systems and their MPI libs at that time. As times changes and projects evolves (MPI implementations), I can see that it is unreasonable to keep these restrictions. I will followup with changes that allows always building the MPI dataplane and set the priority of that dataplane to the lowest in MPI vendors/versions that are known to be difficult.

@vicentebolea vicentebolea added triage: low This issue is a nice-to-have if we can get to it but isn't holding anybody up. area: build Build issues api: C C API related sustainability Related to sustainability effort labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: C C API related area: build Build issues sustainability Related to sustainability effort triage: low This issue is a nice-to-have if we can get to it but isn't holding anybody up.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants