Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize crate name #269

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Capitalize crate name #269

merged 1 commit into from
Jan 30, 2022

Conversation

brycx
Copy link
Member

@brycx brycx commented Jan 30, 2022

Also additional spelling corrections. I took care of the wiki a couple of days ago.

@brycx brycx requested a review from vlmutolo January 30, 2022 16:36
@brycx brycx added this to the v0.17.1 milestone Jan 30, 2022
@brycx brycx linked an issue Jan 30, 2022 that may be closed by this pull request
Correct capitalization of crate name in docs, README and wiki #259
Closed
vlmutolo
vlmutolo approved these changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@vlmutolo vlmutolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I assume you did something like rg orion to find the places that needed to be fixed? (Can we assume these changes are exhaustive?)

@brycx
Copy link
Member Author

brycx commented Jan 30, 2022

This all looks good. I assume you did something like rg orion to find the places that needed to be fixed? (Can we assume these changes are exhaustive?)

Except for the license notice, yes, they should be. I just used the search that Intellij provided, covering all files.

@brycx brycx merged commit ed60c15 into master Jan 30, 2022
@brycx brycx deleted the capitalization branch January 30, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlmutolo vlmutolo vlmutolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.1
Development

Successfully merging this pull request may close these issues.

Correct capitalization of crate name in docs, README and wiki
2 participants
@brycx @vlmutolo