You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out in issue #92 raised by @snsmac, both verify() and secure_cmp currently return Result<Ok(bool), UknownCryptoError>.
Returning a bool is however redundant, as the verification or comparison only will return Ok() if it was successfull and UknownCryptoError if not. If a user needed a bool to represent the result, this could be done with .is_ok()/.is_err().
Because of this, it seems it would make sense to change secure_cmp and all verify() interfaces in orion to return Result<(), UknownCryptoError>, dropping the needless bool.
Before doing so, these new interfaces should be tested in orion-dudect for constant-time execution.
The text was updated successfully, but these errors were encountered:
As pointed out in issue #92 raised by @snsmac, both
verify()
andsecure_cmp
currently returnResult<Ok(bool), UknownCryptoError>
.Returning a
bool
is however redundant, as the verification or comparison only will returnOk()
if it was successfull andUknownCryptoError
if not. If a user needed a bool to represent the result, this could be done with.is_ok()
/.is_err()
.Because of this, it seems it would make sense to change
secure_cmp
and allverify()
interfaces in orion to returnResult<(), UknownCryptoError>
, dropping the needlessbool
.Before doing so, these new interfaces should be tested in orion-dudect for constant-time execution.
The text was updated successfully, but these errors were encountered: