Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 2021 Edition #237

Closed
brycx opened this issue Oct 29, 2021 · 2 comments · Fixed by #302
Closed

Rust 2021 Edition #237

brycx opened this issue Oct 29, 2021 · 2 comments · Fixed by #302
Milestone
0.17.3

Comments

@brycx
Copy link
Member

brycx commented Oct 29, 2021

Rust 2021 Edition has been released and we should probably switch to this. Will bump MSRV to 1.56.0 and should be considered a breaking change.
@brycx brycx added the breaking change A breaking change label Oct 29, 2021
@brycx brycx added this to the v0.17 milestone Oct 29, 2021
@brycx brycx removed this from the v0.17 milestone Nov 24, 2021
@brycx
Copy link
Member Author

brycx commented Nov 24, 2021

Taken off v017 milestone, as this needs some more investigation regarding pros/cons, and if moving to Edition 2021 actually provides us or users with any real benefits.

@brycx brycx mentioned this issue Nov 24, 2021
Open
@brycx
Copy link
Member Author

brycx commented Oct 30, 2022

As the MSRV for edition 2021 is 1.56 and we're on 1.57 as part of a minor release (which doesn't seem to have broken any depending builds), I think it's safe to move to 2021 edition now (the edition isn't forced on depending libraries, only the compatible rustc version). The compatible rustc version was also released more than a year ago. Thus, I'll be removing the breaking change and we can have this as part of a new minor release.

@brycx brycx removed the breaking change A breaking change label Oct 30, 2022
@brycx brycx added this to the 0.17.3 milestone Oct 30, 2022
@brycx brycx mentioned this issue Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.3
Development

Successfully merging a pull request may close this issue.

Migrate to Rust Edition 2021 orion-rs/orion
1 participant
@brycx