-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print - Expose all settings as config options #1172
Merged
jokd
merged 13 commits into
origo-map:master
from
haninge-geodata:print-expose-all-settings-as-config-options
Mar 3, 2021
Merged
Print - Expose all settings as config options #1172
jokd
merged 13 commits into
origo-map:master
from
haninge-geodata:print-expose-all-settings-as-config-options
Mar 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An example config with all the new options:
|
Thanks @jokd, good catch! :) |
jokd
approved these changes
Feb 28, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first PR relating to #1119. Also related to #785.
All current print settings are exposed as config options, letting their default values (and in some cases which values should be allowed) be controlled in the config.
Two maps for testing:
I made the choice to move the default values for most variables out of their respective print controls, the print settings and the print component and put them in the index file. That way all the defaults can be seen and changed in one place instead.
Additionally, the rotation of the map is now reset after closing the print control, so that rotating a map for printing doesn't affect the regular map.